Use rocm-docs-core for linting #370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MathiasMagnus I tried using the scripts but there are some issues here. |
Codecov Report
@@ Coverage Diff @@
## develop #370 +/- ##
========================================
Coverage 58.05% 58.05%
========================================
Files 51 51
Lines 4815 4815
========================================
Hits 2795 2795
Misses 2020 2020
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
I would prefer to wait for ROCm/rocm-docs-core#489 instead, my reasoning being that GitHub is not the primary platform where development happens for rocRAND, so any issues that this linting would uncover would only come up during the upstreaming pull requests. |
samjwu
added
the
ci:static-libraries
saadrahim
requested review from
stanleytsang-amd,
umfranzw,
RobsonRLemos and
lawruble13
as code owners
|
Seems like there's a bunch of failures in CI and also in the files changed section. |
|
PR is stale. Closing. |
Naraenda
pushed a commit
to StreamHPC/rocRAND
that referenced
this pull request
Oct 28, 2024
…lop_stream' Resolve "Add small examples to API documentation" Closes ROCm#370 See merge request amd/libraries/rocRAND!351
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.