New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ortvalue features support for MGX EP #81

Open

urpetkov-amd wants to merge 7 commits into rocm6.3_internal_testing from urpetkov/ortvalue_support

Open

Adding ortvalue features support for MGX EP #81

Updating comments

GitHub Actions / cpplint completed Dec 23, 2024 in 1s

reviewdog [cpplint] report

reported by reviewdog 🐶

Findings (36)

include/onnxruntime/core/session/onnxruntime_c_api.h|639| Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc|16| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc|20| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc|213| Do not indent within a namespace. [whitespace/indent_namespace] [4]
onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc|214| Do not indent within a namespace. [whitespace/indent_namespace] [4]
onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc|215| Do not indent within a namespace. [whitespace/indent_namespace] [4]
onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc|216| Do not indent within a namespace. [whitespace/indent_namespace] [4]
onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc|217| Do not indent within a namespace. [whitespace/indent_namespace] [4]
onnxruntime/core/providers/migraphx/migraphx_execution_provider.h|79| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/migraphx/migraphx_execution_provider.h|80| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc|90| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc|107| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc|108| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc|109| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc|125| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc|78| Add #include for string [build/include_what_you_use] [4]
onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.h|54| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.h|55| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc|8| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc|51| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc|60| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc|64| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc|64| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc|65| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/migraphx/migraphx_provider_factory.h|19| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/migraphx/migraphx_provider_factory.h|19| Add #include for shared_ptr<> [build/include_what_you_use] [4]
onnxruntime/python/onnxruntime_pybind_mlvalue.cc|120| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/python/onnxruntime_pybind_mlvalue.cc|128| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/python/onnxruntime_pybind_mlvalue.cc|232| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/python/onnxruntime_pybind_mlvalue.cc|232| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/python/onnxruntime_pybind_mlvalue.cc|233| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/python/onnxruntime_pybind_ortvalue.cc|61| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/python/onnxruntime_pybind_ortvalue.cc|66| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/python/onnxruntime_pybind_ortvalue.cc|66| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/python/onnxruntime_pybind_ortvalue.cc|67| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/python/onnxruntime_pybind_state_common.cc|48| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]

Filtered Findings (0)

Annotations

Check warning on line 639 in include/onnxruntime/core/session/onnxruntime_c_api.h

github-actions / cpplint

[cpplint] include/onnxruntime/core/session/onnxruntime_c_api.h#L639

Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]

Raw output


            include/onnxruntime/core/session/onnxruntime_c_api.h:639:  Redundant blank line at the end of a code block should be deleted.  [whitespace/blank_line] [3]

Check warning on line 16 in onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc#L16

Include the directory when naming header files [build/include_subdir] [4]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc:16:  Include the directory when naming header files  [build/include_subdir] [4]

Check warning on line 20 in onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc#L20

Include the directory when naming header files [build/include_subdir] [4]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc:20:  Include the directory when naming header files  [build/include_subdir] [4]

Check warning on line 213 in onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc#L213

Do not indent within a namespace. [whitespace/indent_namespace] [4]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc:213:  Do not indent within a namespace.  [whitespace/indent_namespace] [4]

Check warning on line 214 in onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc#L214

Do not indent within a namespace. [whitespace/indent_namespace] [4]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc:214:  Do not indent within a namespace.  [whitespace/indent_namespace] [4]

Check warning on line 215 in onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc#L215

Do not indent within a namespace. [whitespace/indent_namespace] [4]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc:215:  Do not indent within a namespace.  [whitespace/indent_namespace] [4]

Check warning on line 216 in onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc#L216

Do not indent within a namespace. [whitespace/indent_namespace] [4]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc:216:  Do not indent within a namespace.  [whitespace/indent_namespace] [4]

Check warning on line 217 in onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc#L217

Do not indent within a namespace. [whitespace/indent_namespace] [4]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc:217:  Do not indent within a namespace.  [whitespace/indent_namespace] [4]

Check warning on line 79 in onnxruntime/core/providers/migraphx/migraphx_execution_provider.h

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_execution_provider.h#L79

Lines should be <= 120 characters long [whitespace/line_length] [2]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_execution_provider.h:79:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 80 in onnxruntime/core/providers/migraphx/migraphx_execution_provider.h

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_execution_provider.h#L80

Lines should be <= 120 characters long [whitespace/line_length] [2]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_execution_provider.h:80:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 90 in onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc#L90

Lines should be <= 120 characters long [whitespace/line_length] [2]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc:90:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 107 in onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc#L107

Lines should be <= 120 characters long [whitespace/line_length] [2]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc:107:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 108 in onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc#L108

Lines should be <= 120 characters long [whitespace/line_length] [2]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc:108:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 109 in onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc#L109

Lines should be <= 120 characters long [whitespace/line_length] [2]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc:109:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 125 in onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc#L125

Lines should be <= 120 characters long [whitespace/line_length] [2]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc:125:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 78 in onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc#L78

Add #include <string> for string [build/include_what_you_use] [4]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.cc:78:  Add #include <string> for string  [build/include_what_you_use] [4]

Check warning on line 54 in onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.h

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.h#L54

Lines should be <= 120 characters long [whitespace/line_length] [2]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.h:54:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 55 in onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.h

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.h#L55

Lines should be <= 120 characters long [whitespace/line_length] [2]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_execution_provider_info.h:55:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 8 in onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc#L8

Include the directory when naming header files [build/include_subdir] [4]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc:8:  Include the directory when naming header files  [build/include_subdir] [4]

Check warning on line 51 in onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc#L51

Lines should be <= 120 characters long [whitespace/line_length] [2]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc:51:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 60 in onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc#L60

Lines should be <= 120 characters long [whitespace/line_length] [2]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc:60:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 64 in onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc#L64

Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc:64:  Weird number of spaces at line-start.  Are you using a 2-space indent?  [whitespace/indent] [3]

Check warning on line 64 in onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc#L64

Lines should be <= 120 characters long [whitespace/line_length] [2]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc:64:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 65 in onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc#L65

Lines should be <= 120 characters long [whitespace/line_length] [2]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_provider_factory.cc:65:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 19 in onnxruntime/core/providers/migraphx/migraphx_provider_factory.h

github-actions / cpplint

[cpplint] onnxruntime/core/providers/migraphx/migraphx_provider_factory.h#L19

Lines should be <= 120 characters long [whitespace/line_length] [2]

Raw output


            onnxruntime/core/providers/migraphx/migraphx_provider_factory.h:19:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

View more details on GitHub Actions