Skip to content

Commit

Permalink
Updating comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Uros Petkovic committed Dec 23, 2024
1 parent dc06f87 commit 7546036
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions onnxruntime/python/onnxruntime_pybind_ortvalue.cc
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,12 @@ void addOrtValueMethods(pybind11::module& m) {

// InputDeflist is null because OrtValue creation is not tied to a specific model
// Likewise, there is no need to specify the name (as the name was previously used to lookup the def list)
// TODO: Add check to ensure that string arrays are not passed - we currently don't support string tensors in CUDA
// TODO: Add check to ensure that string arrays are not passed - we currently don't support string tensors in ROCm

Check warning on line 61 in onnxruntime/python/onnxruntime_pybind_ortvalue.cc

View workflow job for this annotation

GitHub Actions / cpplint

[cpplint] onnxruntime/python/onnxruntime_pybind_ortvalue.cc#L61

Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Raw output
onnxruntime/python/onnxruntime_pybind_ortvalue.cc:61:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
CreateGenericMLValue(nullptr, GetRocmAllocator(device.Id()), "", array_on_cpu, ml_value.get(), true, false, CpuToRocmMemCpy);
#elif USE_MIGRAPHX
// InputDeflist is null because OrtValue creation is not tied to a specific model
// Likewise, there is no need to specify the name (as the name was previously used to lookup the def list)
// TODO: Add check to ensure that string arrays are not passed - we currently don't support string tensors in CUDA
// TODO: Add check to ensure that string arrays are not passed - we currently don't support string tensors in MIGraphX

Check warning on line 66 in onnxruntime/python/onnxruntime_pybind_ortvalue.cc

View workflow job for this annotation

GitHub Actions / cpplint

[cpplint] onnxruntime/python/onnxruntime_pybind_ortvalue.cc#L66

Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw output
onnxruntime/python/onnxruntime_pybind_ortvalue.cc:66:  Lines should be <= 120 characters long  [whitespace/line_length] [2]

Check warning on line 66 in onnxruntime/python/onnxruntime_pybind_ortvalue.cc

View workflow job for this annotation

GitHub Actions / cpplint

[cpplint] onnxruntime/python/onnxruntime_pybind_ortvalue.cc#L66

Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Raw output
onnxruntime/python/onnxruntime_pybind_ortvalue.cc:66:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
CreateGenericMLValue(nullptr, GetMIGraphXAllocator(device.Id()), "", array_on_cpu, ml_value.get(), true, false, CpuToMIGraphXMemCpy);

Check warning on line 67 in onnxruntime/python/onnxruntime_pybind_ortvalue.cc

View workflow job for this annotation

GitHub Actions / cpplint

[cpplint] onnxruntime/python/onnxruntime_pybind_ortvalue.cc#L67

Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw output
onnxruntime/python/onnxruntime_pybind_ortvalue.cc:67:  Lines should be <= 120 characters long  [whitespace/line_length] [2]
#elif USE_DML
// InputDeflist is null because OrtValue creation is not tied to a specific model
Expand Down

0 comments on commit 7546036

Please sign in to comment.