-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mainline with latest changes from staging #429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <[email protected]>
* Remove `dev` and `main` branch from workflows. Update links in documentation. Signed-off-by: David Galiffi <[email protected]> * `amd-staging` -> `amd-mainline` in docs Signed-off-by: Peter Jun Park <[email protected]> --------- Signed-off-by: David Galiffi <[email protected]> Signed-off-by: Peter Jun Park <[email protected]> Co-authored-by: Peter Jun Park <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: Peter Jun Park <[email protected]>
If we don't add the suffix omniperf to the install path then the subsequent instruction of module load omniperf will not work Signed-off-by: coleramos425 <[email protected]>
…ular plugin (#416) Signed-off-by: coleramos425 <[email protected]>
After meeting with the DevOps team, I've added the Unreleased keyword to new CHANGELOG section per their request Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: Peter Jun Park <[email protected]>
Signed-off-by: Daniel Su <[email protected]>
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure Signed-off-by: coleramos425 <[email protected]> * Apply linting feedback Signed-off-by: coleramos425 <[email protected]> * Update links in MAINTAINERS for new branches Signed-off-by: coleramos425 <[email protected]> * Update MAINTAINERS.md for changelog formatting Signed-off-by: coleramos425 <[email protected]> * Update Omniperf ver checker to allow tags with rocm- prefix Signed-off-by: coleramos425 <[email protected]> * Add step to packaging workflow to upload release tarball to release Signed-off-by: coleramos425 <[email protected]> * Synax change for release name in packaging action Signed-off-by: coleramos425 <[email protected]> * Update MAINTAINERS for instuctions on ROCm releases Signed-off-by: coleramos425 <[email protected]> * Update softprops pluvin to v2 and remove release name Removing the release name enables us to modify an existing release with the matching tag Signed-off-by: coleramos425 <[email protected]> * Remove draft option on softprops plugin Signed-off-by: coleramos425 <[email protected]> --------- Signed-off-by: coleramos425 <[email protected]>
coleramos425
force-pushed
the
amd-staging
branch
from
September 25, 2024 17:24
6265391
to
0d15023
Compare
This PR is ready for rebase and merge. From my perspective the only outstanding TODO in
CC: @njobypeter / @feizheng10 to help complete remaining items |
Signed-off-by: Carrie Fallows <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.