Add the ability to determine GPU model from Chip ID #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coleramos425
requested changes
Sep 10, 2024
There was a problem hiding this comment.
Nice start, but I think this PR is still incomplete. To finish the PR, you'll need to update the populate_mspec() function which sets gpu_model for gfx942 archs to consider your new chip id map
https://github.com/ROCm/omniperf/blob/6bc1a3a1a1bec44d0c3fbbe3993199c071efcecc/src/omniperf_soc/soc_base.py#L187-L200
Once these changes are made, re-request my review, and I can add the original Jira ticket filer as a reviewer
coleramos425
requested changes
Sep 16, 2024
xuchen-amd
force-pushed
the
determine_gpu_model_from_chip_id
branch
2 times, most recently
from
11297ac
to
623c2f9
Compare
xuchen-amd
force-pushed
the
determine_gpu_model_from_chip_id
branch
from
bc1b6c1
to
95e58bf
Compare
coleramos425
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
LGTM. Requesting a review from @skyreflectedinmirrors to see if this satisfies his original request:
https://ontrack-internal.amd.com/browse/SWDEV-461358
skyreflectedinmirrors
requested changes
Sep 19, 2024
skyreflectedinmirrors
requested changes
Sep 19, 2024
xuchen-amd
force-pushed
the
determine_gpu_model_from_chip_id
branch
from
d7b9807
to
6857b2b
Compare
|
Looks good. @xuchen-amd once you fix Python formatting, I will squash and merge. |
…g MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]>
Signed-off-by: xuchen-amd <[email protected]>
…lack. Signed-off-by: xuchen-amd <[email protected]>
Signed-off-by: xuchen-amd <[email protected]>
Signed-off-by: xuchen-amd <[email protected]>
Signed-off-by: xuchen-amd <[email protected]>
…del solely based on chip id. Signed-off-by: xuchen-amd <[email protected]>
Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
force-pushed
the
determine_gpu_model_from_chip_id
branch
2 times, most recently
from
b8ac619
to
efc70df
Compare
coleramos425
pushed a commit
that referenced
this pull request
Sep 25, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
coleramos425
pushed a commit
that referenced
this pull request
Sep 27, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 16, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 17, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 19, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 19, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 19, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 22, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 22, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 22, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 22, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 22, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 23, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 23, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 23, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 23, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 23, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 23, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 24, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 24, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 24, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 24, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
dgaliffiAMD
pushed a commit
to dgaliffiAMD/omniperf
that referenced
this pull request
Oct 24, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
dgaliffiAMD
pushed a commit
to dgaliffiAMD/omniperf
that referenced
this pull request
Oct 24, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
dgaliffiAMD
pushed a commit
to dgaliffiAMD/omniperf
that referenced
this pull request
Oct 24, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
dgaliffiAMD
pushed a commit
to dgaliffiAMD/omniperf
that referenced
this pull request
Oct 24, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 29, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 29, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 29, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 29, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 29, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 29, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
xuchen-amd
added a commit
to xuchen-amd/rocprofiler-compute
that referenced
this pull request
Oct 29, 2024
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to determine GPU model from Chip ID to distinguish MI300 systems by using a built-in dictionary.
The built-in dictionary should be populated to include known chip id to system pairs.