Update device-libs tests for current clang #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update FileCheck test lines to match machine code produced by ROCm-clang in ROCm 6.2 when built against the gfx600 architecture.
Update lines for FileCheck to match compiled machine code for test_fract_f16 to pass tests for gfx600 and gfx700.
arsenm
approved these changes
Aug 16, 2024
searlmc1
pushed a commit
that referenced
this pull request
Aug 22, 2024
…rocm6.2 Update device-libs tests for current clang Change-Id: Iaed89f35e17419153f1124367a9ca463ee767a0d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests in amd/device-libs to pass for ROCm-clang packaged with ROCm 6.2. Lines are updated to match machine code produced with this version of clang. Addresses issue #76, as user's machine code resulting from upstream-clang matches current ROCm-clang result. Affected tests are test_fract_f16 for gfx600 and gfx700, and test_frexp_f32 and test_frexp_f64 for gfx600.