Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: 11/12/24 upstream sync #136

Merged
merged 71 commits into from
Nov 12, 2024
Merged

CI: 11/12/24 upstream sync #136

merged 71 commits into from
Nov 12, 2024

Conversation

github-actions[bot]
Copy link

Daily sync with upstream

froystig and others added 30 commits November 7, 2024 07:32
This is an initial draft. There is more to come back and add/improve.
… with `gcc`

This update is a follow-up of PR jax-ml#23852. In the previous PR, there was one missing place where the `typename` was not added.
PiperOrigin-RevId: 694372268
PiperOrigin-RevId: 694426328
We only recently started using this in tests and it has caused ASAN
to report a bunch of leaks.

PiperOrigin-RevId: 694510867
This test is failing in CI.

PiperOrigin-RevId: 694574616
There are numerical errors from the complex plane function tests.

PiperOrigin-RevId: 694579368
PiperOrigin-RevId: 694622626
…es to the MLIR Mosaic GPU Dialect.

PiperOrigin-RevId: 694643777
…lunking

through the trace stack to find it.

PiperOrigin-RevId: 694710181
chr1sj0nes and others added 26 commits November 11, 2024 09:46
…opper-tests

PiperOrigin-RevId: 695388748
…sent for memory refs.

PiperOrigin-RevId: 695414469
Helps resolve the following issue, where invoking HLO's cost analysis triggers compilation which can OOM for larger inputs: jax-ml#24539. This cost estimator uses only abstract evaluation which should work for all input sizes.

PiperOrigin-RevId: 695415760
…/actions/cache-4.1.2

PiperOrigin-RevId: 695460084
…memref is untiled

* Generalize any untiled memref to have tiling (packing, 128)
* Support dynamic index on 2nd minor.
* Support dynamic shape on 2nd minor.

PiperOrigin-RevId: 695516124
PiperOrigin-RevId: 695603337
In some cases, `compilation_cache.is_cache_used` can reach the end of the function body without returning anything. This amounts to an implicit `return None`, which is not in line with the functions return type of `bool`. We fix this by adding a final `return False` to the function.
Removes the outfeed rewriter mechanism and helper functions
`jaxpr_uses_outfeed`, which were used only by
`jax.experimental.host_callback`.
Previously, `jvp(lax.sort)` used a shape-dependent dtype, for
the types of indices (either `int32` or `int64`, depending on
the size of the dimension). For shape polymorphism, input shapes
can affect other intermediate shapes, but not `dtype`s.

In this case it is easy to just use `int46` independent of
the actual shape.
Previously, it was recomputing them at every loop iteration.

PiperOrigin-RevId: 695682116
`xla::HostCallbackArgInfo` uses `uint16_t` for channel ids, so we should warn users explicitly when the channel ids exceed the UINT16_MAX instead of silently wrapping around.

PiperOrigin-RevId: 695682871
As reported in jax-ml#24794, there were some dot products that were resulting in an unnecessary conversion. This change makes the output storage type selection more flexible.

Fixes jax-ml#24794

PiperOrigin-RevId: 695694179
As reported in jax-ml#24843, our LU decomposition on GPU hits overflow errors when the batch size approaches int32 max. This was caused by an issue in how we were constructing the batched pointers used by cuBLAS.

PiperOrigin-RevId: 695694648
@charleshofer charleshofer self-requested a review November 12, 2024 17:50
@charleshofer charleshofer merged commit d0f6b95 into rocm-main Nov 12, 2024
7 checks passed
@charleshofer charleshofer deleted the ci-upstream-sync-16_1 branch November 12, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.