Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove merge-files option #1407

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

ellosel
Copy link
Contributor

@ellosel ellosel commented Nov 28, 2024

In efforts to simplify TensileCreateLibrary and recognizing that primary consumers exclusively use merge-files, we are removing the merge-files option along with num-merge-files. If this option is needed in the future, we can restore this behavior but in such a way that we follow the open/closed principle.

@KKyang
Copy link
Contributor

KKyang commented Nov 28, 2024

We still need mergeFiles=False feature when tuning using config yaml in TensileLite.

@ellosel
Copy link
Contributor Author

ellosel commented Nov 28, 2024

We still need mergeFiles=False feature when tuning using config yaml in TensileLite.

Can you explain how it is used in that context? What do you mean by

tuning using config yaml in TensileLite

There are tests that specify MergeFiles=False but they pass with MergeFiles=True. Is MergeFiles used during the current tuning process? We may still want to remove it from TensileCreateLibrary but expose that option through Tensile.

@bstefanuk
Copy link
Contributor

I am also interested in learning more about how MergeFiles=False is used during tuning.

Either way, this update cleans up a lot of (what appears to be) unused code in TensileCreateLibrary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants