Passing block_count for memcpy dScaleAB. #1190
Open
+23
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengzcai
requested review from
jichangjichang,
KKyang,
aazz44ss,
vin-huang,
imcarsonliao,
hcman2,
Serge45,
Jinp800125,
TonyYHsieh and
solaslin
as code owners
aazz44ss
approved these changes
Oct 1, 2024
| @@ -1536,20 +1536,20 @@ void testing_matmul_with_bias(const Arguments& arg, | |||
| B_row[i], | |||
| B_col[i], | |||
| stream)); | |||
| CHECK_HIP_ERROR(synchronize(hScaleB[i], dScaleB[i])); | |||
| CHECK_HIP_ERROR(transfer_from(hScaleB[i], dScaleB[i])); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug where --rotating, --scaleA and --scaleB were enabled in the hipblaslt-bench:
dScale should copy the memory from hScale for 'block_count' times.