Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add vector scale a and b in sample code #1163

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

add vector scale a and b in sample code #1163

wants to merge 1 commit into from
+390 −1

Conversation

tsenwang
Copy link
Contributor

No description provided.

@tsenwang
Copy link
Contributor Author

Running tests...
Test project /Workspace/hipBLASLt/build/release
Start 1: sample_hipblaslt_gemm
1/40 Test #1: sample_hipblaslt_gemm ............................... Passed 1.50 sec
Start 2: sample_hipblaslt_gemm_ext
2/40 Test #2: sample_hipblaslt_gemm_ext ........................... Passed 1.11 sec
Start 3: sample_hipblaslt_gemm_batched
3/40 Test #3: sample_hipblaslt_gemm_batched ....................... Passed 1.39 sec
Start 4: sample_hipblaslt_gemm_batched_ext
4/40 Test #4: sample_hipblaslt_gemm_batched_ext ................... Passed 1.83 sec
Start 5: sample_hipblaslt_gemm_tuning_splitk_ext
5/40 Test #5: sample_hipblaslt_gemm_tuning_splitk_ext ............. Passed 13.14 sec
Start 6: sample_hipblaslt_gemm_bias
6/40 Test #6: sample_hipblaslt_gemm_bias .......................... Passed 1.07 sec
Start 7: sample_hipblaslt_gemm_bias_ext
7/40 Test #7: sample_hipblaslt_gemm_bias_ext ...................... Passed 0.89 sec
Start 8: sample_hipblaslt_gemm_get_all_algos
8/40 Test #8: sample_hipblaslt_gemm_get_all_algos ................. Passed 13.67 sec
Start 9: sample_hipblaslt_gemm_get_all_algos_ext
9/40 Test #9: sample_hipblaslt_gemm_get_all_algos_ext ............. Passed 12.01 sec
Start 10: sample_hipblaslt_gemm_get_algo_by_index_ext
10/40 Test #10: sample_hipblaslt_gemm_get_algo_by_index_ext ......... Passed 11.57 sec
Start 11: sample_hipblaslt_gemm_alphavec_ext
11/40 Test #11: sample_hipblaslt_gemm_alphavec_ext .................. Passed 1.06 sec
Start 12: sample_hipblaslt_gemm_gelu_aux_bias
12/40 Test #12: sample_hipblaslt_gemm_gelu_aux_bias ................. Passed 0.85 sec
Start 13: sample_hipblaslt_gemm_gelu_aux_bias_ext
13/40 Test #13: sample_hipblaslt_gemm_gelu_aux_bias_ext ............. Passed 0.67 sec
Start 14: sample_hipblaslt_gemm_amax
14/40 Test #14: sample_hipblaslt_gemm_amax .......................... Passed 0.69 sec
Start 15: sample_hipblaslt_gemm_amax_ext
15/40 Test #15: sample_hipblaslt_gemm_amax_ext ...................... Passed 0.73 sec
Start 16: sample_hipblaslt_gemm_amax_with_scale
16/40 Test #16: sample_hipblaslt_gemm_amax_with_scale ............... Passed 0.71 sec
Start 17: sample_hipblaslt_gemm_amax_with_scale_ext
17/40 Test #17: sample_hipblaslt_gemm_amax_with_scale_ext ........... Passed 0.70 sec
Start 18: sample_hipblaslt_gemm_bgradb
18/40 Test #18: sample_hipblaslt_gemm_bgradb ........................ Passed 0.95 sec
Start 19: sample_hipblaslt_gemm_ext_bgradb
19/40 Test #19: sample_hipblaslt_gemm_ext_bgradb .................... Passed 0.67 sec
Start 20: sample_hipblaslt_gemm_dgelu_bgrad
20/40 Test #20: sample_hipblaslt_gemm_dgelu_bgrad ................... Passed 0.69 sec
Start 21: sample_hipblaslt_gemm_dgelu_bgrad_ext
21/40 Test #21: sample_hipblaslt_gemm_dgelu_bgrad_ext ............... Passed 1.01 sec
Start 22: sample_hipblaslt_gemm_is_tuned_ext
22/40 Test #22: sample_hipblaslt_gemm_is_tuned_ext .................. Passed 0.76 sec
Start 23: sample_hipblaslt_gemm_tuning_wgm_ext
23/40 Test #23: sample_hipblaslt_gemm_tuning_wgm_ext ................ Passed 12.93 sec
Start 24: sample_hipblaslt_gemm_with_scale_a_b
24/40 Test #24: sample_hipblaslt_gemm_with_scale_a_b ................ Passed 12.65 sec
Start 25: sample_hipblaslt_gemm_with_scale_a_b_ext
25/40 Test #25: sample_hipblaslt_gemm_with_scale_a_b_ext ............ Passed 0.84 sec
Start 26: sample_hipblaslt_groupedgemm_ext
26/40 Test #26: sample_hipblaslt_groupedgemm_ext .................... Passed 2.69 sec
Start 27: sample_hipblaslt_groupedgemm_fixed_mk_ext
27/40 Test #27: sample_hipblaslt_groupedgemm_fixed_mk_ext ........... Passed 11.65 sec
Start 28: sample_hipblaslt_groupedgemm_get_all_algos_ext
28/40 Test #28: sample_hipblaslt_groupedgemm_get_all_algos_ext ...... Passed 13.10 sec
Start 29: sample_hipblaslt_gemm_mix_precision
29/40 Test #29: sample_hipblaslt_gemm_mix_precision ................. Passed 0.71 sec
Start 30: sample_hipblaslt_gemm_mix_precision_ext
30/40 Test #30: sample_hipblaslt_gemm_mix_precision_ext ............. Passed 1.99 sec
Start 31: sample_hipblaslt_gemm_mix_precision_with_amax_ext
31/40 Test #31: sample_hipblaslt_gemm_mix_precision_with_amax_ext ... Passed 0.99 sec
Start 32: sample_hipblaslt_gemm_attr_tciA_tciB
32/40 Test #32: sample_hipblaslt_gemm_attr_tciA_tciB ................ Passed 0.65 sec
Start 33: sample_hipblaslt_ext_op_layernorm
33/40 Test #33: sample_hipblaslt_ext_op_layernorm ................... Passed 0.50 sec
Start 34: sample_hipblaslt_gemm_ext_deprecated
34/40 Test #34: sample_hipblaslt_gemm_ext_deprecated ................ Passed 1.07 sec
Start 35: sample_hipblaslt_ext_op_amax
35/40 Test #35: sample_hipblaslt_ext_op_amax ........................ Passed 0.53 sec
Start 36: sample_hipblaslt_ext_op_amax_with_scale
36/40 Test #36: sample_hipblaslt_ext_op_amax_with_scale ............. Passed 0.74 sec
Start 37: sample_hipblaslt_gemm_scale_a_b_vector
37/40 Test #37: sample_hipblaslt_gemm_scale_a_b_vector .............. Passed 1.14 sec
Start 38: sample_hipblaslt_gemm_scale_a_b_vector_ext
38/40 Test #38: sample_hipblaslt_gemm_scale_a_b_vector_ext .......... Passed 1.20 sec
Start 39: hipblaslt-bench-groupedgemm-fixed-mk
39/40 Test #39: hipblaslt-bench-groupedgemm-fixed-mk ................ Passed 236.44 sec
Start 40: hipblaslt-test
40/40 Test #40: hipblaslt-test ...................................... Passed 2602.43 sec

100% tests passed, 0 tests failed out of 40

Total Test time (real) = 2969.91 sec

jichangjichang
jichangjichang reviewed Sep 25, 2024
View reviewed changes
clients/samples/25_gemm_scale_a_b_vector/sample_hipblaslt_gemm_scale_a_b_vector.cpp
if(returnedAlgoCount == 0)
{
std::cerr << "No valid solution found!" << std::endl;
return;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also free the allocated memory and descriptor before early return

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create another PR to free the allocated memory and descriptor before early return in every sample code

jichangjichang
jichangjichang reviewed Sep 25, 2024
View reviewed changes
clients/samples/25_gemm_scale_a_b_vector_ext/sample_hipblaslt_gemm_scale_a_b_vector_ext.cpp
CHECK_HIPBLASLT_ERROR(gemm.initialize(heuristicResult[0].algo, d_workspace));
CHECK_HIPBLASLT_ERROR(gemm.run(stream));

std::cout << "Matrix multiplication completed successfully." << std::endl;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

free memory

jichangjichang
jichangjichang reviewed Sep 25, 2024
View reviewed changes
clients/samples/25_gemm_scale_a_b_vector_ext/sample_hipblaslt_gemm_scale_a_b_vector_ext.cpp Outdated
std::vector<float> scale_a(128, 0.5f); // Scale A vector setting
std::vector<float> scale_b(128, 2.0f); // Scale B vector setting

std::cout << "Running with Scale A = [0.5, ..., 0.5], Scale B = [2.0, ..., 2.0]" << std::endl;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to use different value for each scale A element since this example is scale A/B VECTOR but not scalar.

jichangjichang
jichangjichang reviewed Sep 25, 2024
View reviewed changes
clients/samples/25_gemm_scale_a_b_vector_ext/sample_hipblaslt_gemm_scale_a_b_vector_ext.cpp Outdated

int main()
{
// This is an example using hipblaslt extension API: ScaleA & ScaleB & ScaleC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no ScaleC in this example

@tsenwang
add vector scale a and b
a051f8a 
add a and b vector scale
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichangjichang jichangjichang jichangjichang left review comments

@KKyang KKyang Awaiting requested review from KKyang KKyang is a code owner

@aazz44ss aazz44ss Awaiting requested review from aazz44ss aazz44ss is a code owner

@vin-huang vin-huang Awaiting requested review from vin-huang vin-huang is a code owner

@imcarsonliao imcarsonliao Awaiting requested review from imcarsonliao imcarsonliao is a code owner

@hcman2 hcman2 Awaiting requested review from hcman2 hcman2 is a code owner

@Serge45 Serge45 Awaiting requested review from Serge45 Serge45 is a code owner

@Jinp800125 Jinp800125 Awaiting requested review from Jinp800125 Jinp800125 is a code owner

@TonyYHsieh TonyYHsieh Awaiting requested review from TonyYHsieh TonyYHsieh is a code owner

@solaslin solaslin Awaiting requested review from solaslin solaslin is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsenwang @jichangjichang