Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CK_TILE] Fix fMHA fwd MakeKargs() compilation errors #1689

Merged
merged 3 commits into from
Nov 25, 2024
Merged

[CK_TILE] Fix fMHA fwd MakeKargs() compilation errors #1689

merged 3 commits into from
Nov 25, 2024

Conversation

poyenc
Copy link
Contributor

@poyenc poyenc commented Nov 22, 2024 •
edited
Loading

This is follow-up PR of #1638, fix errors introduced in #1681

  • Rename std::variant<> version MakeKargs() as MakeKargsImpl() (prevent ambiguity if user calls MakeKargs() and pass list initializer argument)
  • Add missing return in MakeKargs()
  • Replace __host__ with CK_TILE_HOST macros

@poyenc poyenc self-assigned this Nov 22, 2024
@poyenc poyenc changed the title [CK_TILE] Fix fMHA MakeKargs() compilation errors [CK_TILE] Fix fMHA fwd MakeKargs() compilation errors Nov 22, 2024
@poyenc poyenc marked this pull request as draft November 22, 2024 23:32
@poyenc poyenc marked this pull request as ready for review November 23, 2024 00:31
@poyenc poyenc merged commit 645fe81 into develop Nov 25, 2024
2 of 5 checks passed
@poyenc poyenc deleted the feature/fix-fmha-makekargs-signature branch November 25, 2024 07:30
@schung-amd schung-amd mentioned this pull request Nov 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qianfengz qianfengz qianfengz approved these changes

@junliume junliume Awaiting requested review from junliume junliume is a code owner

@illsilin illsilin Awaiting requested review from illsilin illsilin is a code owner

@carlushuang carlushuang Awaiting requested review from carlushuang carlushuang is a code owner

@aosewski aosewski Awaiting requested review from aosewski aosewski is a code owner

@geyyer geyyer Awaiting requested review from geyyer geyyer is a code owner

@bartekxk bartekxk Awaiting requested review from bartekxk bartekxk is a code owner

@andriy-ca andriy-ca Awaiting requested review from andriy-ca andriy-ca is a code owner

Assignees

@poyenc poyenc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poyenc @qianfengz