Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-map tests for TDD #838

Open
wants to merge 1 commit into
base: aomp-dev
Choose a base branch
from
Open

Self-map tests for TDD #838

wants to merge 1 commit into from

Conversation

ThorBl
Copy link
Contributor

@ThorBl ThorBl commented Feb 28, 2024

These tests are used in a TDD fashion and will be extended along the way. They currently fail due to missing support in the frontend (syntax error).

These tests are used in a TDD fashion and will be extended along the way. They currently fail due to mssing support in the frontend.

Change-Id: I6a4f7d58fe333250c256c0d0dfd7a18c717026c8
@jplehr
Copy link
Contributor

jplehr commented Feb 28, 2024

I think I understand the motivation, however, please note that these tests will not work as intended in the make check rule which is used by the check_XYZ scripts.
I believe there are two paths forward: Split the test cases into two separate tests, each with its own Makefile and thus RUCMD or use a script that would to the actual execution, testing and indicate via return code whether it was successful.
WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants