Added a warning that shows up if someone wants to build AOMP for the untested targets aarch64 or ppc64le #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…untestet targets aarch64 or ppc64le. Since the targets are completly untested I added a warning instead of a comment. Even if the probability that these targets will be built is vanishingly small. In the long run maybe the complete logic for these targets can be removed from the scripts.
ThorBl
changed the title
ronlieb
reviewed
Jul 31, 2024
bin/build_project.sh
Outdated
| @@ -37,6 +37,10 @@ REPO_DIR=$AOMP_REPOS/$AOMP_PROJECT_REPO_NAME | |||
| patchrepo $REPO_DIR | |||
|
|
|||
| # End check-openmp prep | |||
| if [ "$AOMP_PROC" == "ppc64le" ] || [ "$AOMP_PROC" == "aarch64" ] ; then | |||
| echo "WARNING: You are about to build AOMP for the *untested* target $AOMP_PROC. Press enter to continue." | |||
| read | |||
There was a problem hiding this comment.
if someone runs the build and redirects all output to a log file, will this hang waiting for a keyboard response ?
There was a problem hiding this comment.
Yes, it will hang. I only tested it with "|& tee". I will use sleep instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the targets are completely untested, I added a warning instead of a comment. The complete logic for these targets may be removed from the scripts in the long run.