Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment checks #678

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Deployment checks #678

wants to merge 7 commits into from

Conversation

manoj-freyr
Copy link
Collaborator

Display rocm version, OS, vbios and firmware vesions for the current running rvs environment.

rvs/CMakeLists.txt Outdated Show resolved Hide resolved
src/rvs_util.cpp Outdated Show resolved Hide resolved
src/rvs_util.cpp Outdated Show resolved Hide resolved
src/rvs_util.cpp Show resolved Hide resolved
@jkottiku
Copy link
Collaborator

OS and kernel versions also would be good add ons. Maybe can done as next upgrade.

@@ -231,9 +319,17 @@ int display_gpu_info (void) {
info.node_id = node_id;
info.gpu_id = gpu_id;
info.device_id = dev_id;
auto ret = rsmi_dev_vbios_version_get(i, info.vbios_ver, 1024);// check returns TODO
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check return value ?

@jkottiku jkottiku self-requested a review January 15, 2024 20:55
@manoj-freyr
Copy link
Collaborator Author

OS and kernel versions also would be good add ons. Maybe can done as next upgrade.

yeah can add later, but avoided as it is not directly correlated to ROCm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants