Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduction to HIP #3549

Merged
merged 9 commits into from
Jul 31, 2024
Merged

Introduction to HIP #3549

merged 9 commits into from
Jul 31, 2024

Conversation

randyh62
Copy link

Add Introduction to HIP
Combine Programming Model and Programming Model Reference
Update links on index and TOC

@randyh62 randyh62 added ci:docs-only Only run Read the Docs CI on this PR documentation labels Jul 22, 2024
@randyh62 randyh62 requested review from neon60, chrispaquot and a team July 22, 2024 21:34
neon60
neon60 reviewed Jul 23, 2024
View reviewed changes
docs/understand/programming_model.rst Outdated
make efficient use of HIP and general purpose graphics processing unit (GPGPU)
programming in general.


Copy link
Contributor

@neon60 neon60 Jul 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this extra line.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the extra line

@randyh62 randyh62 requested a review from neon60 July 23, 2024 21:58
@randyh62 randyh62 merged commit 628fa8b into ROCm:docs/develop Jul 31, 2024
3 checks passed
MKKnorr
MKKnorr reviewed Aug 2, 2024
View reviewed changes
Copy link

@MKKnorr MKKnorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left most of understand/programming_model.rst unreviewed as it's just a copy. It might still need to be refactored at some point.

Otherwise I think my main criticism is the intermingled usage of "ROCm", "HIP" and "CUDA"

docs/index.md Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
docs/understand/introduction_to_hip.rst Show resolved Hide resolved
docs/understand/introduction_to_hip.rst Show resolved Hide resolved
docs/understand/introduction_to_hip.rst Show resolved Hide resolved
docs/understand/introduction_to_hip.rst Show resolved Hide resolved
docs/understand/introduction_to_hip.rst Show resolved Hide resolved
docs/understand/programming_model.rst Show resolved Hide resolved
docs/understand/programming_model.rst Show resolved Hide resolved
docs/understand/programming_model.rst Show resolved Hide resolved
@neon60
Copy link
Contributor

neon60 commented Aug 2, 2024

@randyh62 Opened a new PR: #3558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MKKnorr MKKnorr MKKnorr left review comments

@lpaoletti lpaoletti lpaoletti approved these changes

@chrispaquot chrispaquot Awaiting requested review from chrispaquot chrispaquot is a code owner

@gandryey gandryey Awaiting requested review from gandryey gandryey is a code owner

@mangupta mangupta Awaiting requested review from mangupta mangupta is a code owner

@rakesroy rakesroy Awaiting requested review from rakesroy rakesroy is a code owner

@neon60 neon60 Awaiting requested review from neon60

Assignees

@neon60 neon60

@lpaoletti lpaoletti

Labels
ci:docs-only Only run Read the Docs CI on this PR documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@randyh62 @neon60 @MKKnorr @lpaoletti