Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix case typo in hipTexRefGetMipMappedArray #3343

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix case typo in hipTexRefGetMipMappedArray #3343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0af2f8a
fix typo
hmacdope Oct 3, 2023
a05023e
Merge branch 'develop' into mmapped_typo
hmacdope Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/reference/deprecated_api_list.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ Should use roctracer/rocTX instead
### hipTexRefGetMipmapFilterMode
### hipTexRefGetMipmapLevelBias
### hipTexRefGetMipmapLevelClamp
### hipTexRefGetMipMappedArray
### hipTexRefGetMipmappedArray
### hipTexRefSetAddress
### hipTexRefSetAddress2D
### hipTexRefSetMaxAnisotropy
Expand Down
2 changes: 1 addition & 1 deletion include/hip/hip_runtime_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6168,7 +6168,7 @@ hipError_t hipTexRefGetMipmapLevelClamp(
*
*/
DEPRECATED(DEPRECATED_MSG)
hipError_t hipTexRefGetMipMappedArray(
hipError_t hipTexRefGetMipmappedArray(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may need to be two functions going to one, this is a breaking change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to clarify you would like to have two functions same functionality with different names?

hipMipmappedArray_t* pArray,
const textureReference* texRef);
/**
Expand Down