-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuse reshapes across concat #3637
base: develop
Are you sure you want to change the base?
Conversation
More tests are needed for this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3637 +/- ##
===========================================
+ Coverage 92.18% 92.19% +0.01%
===========================================
Files 513 513
Lines 21576 21633 +57
===========================================
+ Hits 19889 19945 +56
- Misses 1687 1688 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
auto x = m2.add_parameter("x", s); | ||
auto y = m2.add_parameter("y", s); | ||
auto concat = m2.add_instruction(migraphx::make_op("concat", {{"axis", 0}}), x, y); | ||
// TODO: This could just be a broadcast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this a separate issue and queue it up if this a todo if it offers a perf benifit or not.
rekicking CI, having another odd timeout. Looks good btw. |
This build is not recommended to merge 🔴 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
No description provided.