Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuse reshapes across concat #3637

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fuse reshapes across concat #3637

wants to merge 4 commits into from

Conversation

pfultz2
Copy link
Collaborator

@pfultz2 pfultz2 commented Nov 19, 2024

No description provided.

@pfultz2
Copy link
Collaborator Author

pfultz2 commented Nov 19, 2024

More tests are needed for this.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (ed3037e) to head (581be4c).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3637      +/-   ##
===========================================
+ Coverage    92.18%   92.19%   +0.01%     
===========================================
  Files          513      513              
  Lines        21576    21633      +57     
===========================================
+ Hits         19889    19945      +56     
- Misses        1687     1688       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

auto x = m2.add_parameter("x", s);
auto y = m2.add_parameter("y", s);
auto concat = m2.add_instruction(migraphx::make_op("concat", {{"axis", 0}}), x, y);
// TODO: This could just be a broadcast
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a separate issue and queue it up if this a todo if it offers a perf benifit or not.

@TedThemistokleous TedThemistokleous added Matchers Updates or adds a change to compile time Matchers Perf Improve labels Nov 23, 2024
@TedThemistokleous
Copy link
Collaborator

TedThemistokleous commented Nov 23, 2024

rekicking CI, having another odd timeout. Looks good btw.

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
581be4
Rate old
0ad807
Diff Compare
torchvision-resnet50 64 3,258.57 3,239.44 0.59%
torchvision-resnet50_fp16 64 6,979.79 6,989.98 -0.15%
torchvision-densenet121 32 2,433.37 2,435.40 -0.08%
torchvision-densenet121_fp16 32 4,078.79 4,083.28 -0.11%
torchvision-inceptionv3 32 1,628.64 1,630.36 -0.11%
torchvision-inceptionv3_fp16 32 2,743.06 2,743.98 -0.03%
cadene-inceptionv4 16 765.34 765.72 -0.05%
cadene-resnext64x4 16 809.92 811.01 -0.13%
slim-mobilenet 64 7,466.45 7,471.20 -0.06%
slim-nasnetalarge 64 208.52 208.50 0.01%
slim-resnet50v2 64 3,442.14 3,438.88 0.09%
bert-mrpc-onnx 8 1,152.79 1,147.12 0.49%
bert-mrpc-tf 1 470.72 469.98 0.16%
pytorch-examples-wlang-gru 1 417.96 416.34 0.39%
pytorch-examples-wlang-lstm 1 425.98 463.26 -8.05% 🔴
torchvision-resnet50_1 1 785.27 770.23 1.95%
cadene-dpn92_1 1 400.32 399.89 0.11%
cadene-resnext101_1 1 383.10 382.62 0.12%
onnx-taau-downsample 1 345.40 345.09 0.09%
dlrm-criteoterabyte 1 33.36 33.34 0.06%
dlrm-criteoterabyte_fp16 1 52.73 52.72 0.02%
agentmodel 1 8,416.23 10,261.49 -17.98% 🔴
unet_fp16 2 58.86 58.87 -0.02%
resnet50v1_fp16 1 928.52 982.51 -5.49% 🔴
resnet50v1_int8 1 1,013.25 1,007.17 0.60%
bert_base_cased_fp16 64 1,170.86 1,169.34 0.13%
bert_large_uncased_fp16 32 362.96 363.46 -0.13%
bert_large_fp16 1 200.14 198.15 1.01%
distilgpt2_fp16 16 2,198.22 2,201.47 -0.15%
yolov5s 1 533.86 536.48 -0.49%
tinyllama 1 43.72 43.38 0.78%
vicuna-fastchat 1 176.76 172.97 2.19%
whisper-tiny-encoder 1 418.10 418.04 0.01%
whisper-tiny-decoder 1 434.76 423.83 2.58%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Matchers Updates or adds a change to compile time Matchers Perf Improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants