Change GFX number checking for fp8 hw support #3634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CharlieL7
commented
Nov 19, 2024
CharlieL7
commented
- Enable fp8ocp for upcoming hardware
causten
reviewed
Nov 19, 2024
| @@ -52,13 +52,15 @@ std::string get_device_name() | |||
| bool gfx_has_fp8fnuz_intrinsics() | |||
| { | |||
| const auto device_name = trim(split_string(get_device_name(), ':').front()); | |||
| return (starts_with(device_name, "gfx9") and device_name >= "gfx940"); | |||
| return (starts_with(device_name, "gfx94")); | |||
There was a problem hiding this comment.
How do you deal with MI100, MI2xx ?
There was a problem hiding this comment.
They don't officially support fp8. They weren't going through with the previous condition anyways.
| } | ||
|
|
||
| bool gfx_has_fp8ocp_intrinsics() | ||
| { | ||
| const auto device_name = trim(split_string(get_device_name(), ':').front()); | ||
| return (starts_with(device_name, "gfx12") and device_name >= "gfx1200"); | ||
| bool is_navi4x = starts_with(device_name, "gfx12") and device_name >= "gfx1200"; | ||
| bool is_mi35x = starts_with(device_name, "gfx9") and device_name >= "gfx950"; |
There was a problem hiding this comment.
I get what you are trying to do here, just be mindful of future work. If there is ever a mi36x the next person wouldn't need to make a code change here since the gfx number "should" increase in number. Yet the variable being named mi35x would still cause someone to come look at the code and have to think about the intention. is_mi_fp8ocp may show intent with less head scratching for the next developer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.