-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement BF16 using generic_float class #3578
Conversation
{ | ||
static std::string format() | ||
{ | ||
// TODO: no standard format in numpy for bf16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be an issue or is this tracked somewhere already?
@richagadgil update your description. I think we've done a pass on this with some comments. |
For the CI failures, just add an if statement to skip bf16 for now in the |
Check results before merge 🔆 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
Uses generic float class (#3522) to create bf16 class.
BF16 has 1 sign bit, 8 bits for the exponent, and 7 bits for the mantissa:
bf16 = migraphx::generic_float<7, 8>;
Summary of changes: