Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call compile with correct executable #3493

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
+7 −1
Draft

Call compile with correct executable #3493

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
433286a
import fix
richagadgil Oct 1, 2024
bdfaa6f
remove comment
richagadgil Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/targets/gpu/compile_hip.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,15 @@
bool hip_has_flags(const std::vector<std::string>& flags)
{
hiprtc_program prog{" "};

std::string src = " ";
src_file input{"main.cpp", src};
std::vector<src_file> srcs = { input };
std::string arch = "gfx900";

Check warning on line 235 in src/targets/gpu/compile_hip.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

style: The scope of the variable 'arch' can be reduced. [variableScope]

try
{
prog.compile(flags, true);
compile_hip_src(srcs, flags, arch);
return true;
}
catch(...)
Expand Down
Loading