Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RNN-T Imports #3474

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Update RNN-T Imports #3474

merged 5 commits into from
Oct 3, 2024

Conversation

richagadgil
Copy link
Contributor

@richagadgil richagadgil commented Sep 25, 2024

Imports causing RNN-T Errors

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (46a80f2) to head (ab85e0a).
Report is 21 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3474      +/-   ##
===========================================
- Coverage    92.04%   92.02%   -0.03%     
===========================================
  Files          506      509       +3     
  Lines        20872    21005     +133     
===========================================
+ Hits         19212    19330     +118     
- Misses        1660     1675      +15     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richagadgil richagadgil changed the title working pyhon script Update RNN-T Imports Sep 25, 2024
@richagadgil richagadgil self-assigned this Sep 27, 2024
@richagadgil richagadgil marked this pull request as ready for review October 1, 2024 01:58
@richagadgil richagadgil requested a review from a team as a code owner October 2, 2024 21:17
@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
ab85e0
Rate old
e2e921
Diff Compare
torchvision-resnet50 64 3,261.65 3,255.97 0.17%
torchvision-resnet50_fp16 64 6,986.08 6,971.30 0.21%
torchvision-densenet121 32 2,436.46 2,431.20 0.22%
torchvision-densenet121_fp16 32 4,101.67 4,087.45 0.35%
torchvision-inceptionv3 32 1,637.46 1,635.71 0.11%
torchvision-inceptionv3_fp16 32 2,745.39 2,755.82 -0.38%
cadene-inceptionv4 16 779.00 780.33 -0.17%
cadene-resnext64x4 16 808.75 806.94 0.22%
slim-mobilenet 64 7,463.95 7,464.88 -0.01%
slim-nasnetalarge 64 208.46 208.51 -0.02%
slim-resnet50v2 64 3,442.99 3,435.02 0.23%
bert-mrpc-onnx 8 1,152.37 1,146.59 0.50%
bert-mrpc-tf 1 318.39 318.44 -0.01%
pytorch-examples-wlang-gru 1 411.02 421.02 -2.38%
pytorch-examples-wlang-lstm 1 392.48 374.33 4.85% 🔆
torchvision-resnet50_1 1 811.68 803.63 1.00%
cadene-dpn92_1 1 400.36 395.85 1.14%
cadene-resnext101_1 1 381.32 379.14 0.58%
onnx-taau-downsample 1 344.94 366.52 -5.89% 🔴
dlrm-criteoterabyte 1 35.06 35.01 0.13%
dlrm-criteoterabyte_fp16 1 58.18 58.19 -0.02%
agentmodel 1 8,191.15 8,063.61 1.58%
unet_fp16 2 57.95 58.95 -1.69%
resnet50v1_fp16 1 1,000.90 950.25 5.33% 🔆
resnet50v1_int8 1 977.83 971.97 0.60%
bert_base_cased_fp16 64 1,174.54 1,170.73 0.33%
bert_large_uncased_fp16 32 363.18 363.46 -0.08%
bert_large_fp16 1 211.47 213.45 -0.93%
distilgpt2_fp16 16 2,208.97 2,199.49 0.43%
yolov5s 1 532.70 539.25 -1.22%
tinyllama 1 43.49 43.47 0.05%
vicuna-fastchat 1 168.88 174.86 -3.42% 🔴
whisper-tiny-encoder 1 417.82 417.66 0.04%
whisper-tiny-decoder 1 419.40 427.92 -1.99%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

Copy link
Contributor

@spolifroni-amd spolifroni-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes to any wording/language, so it's fine from a docs perspective.

@causten causten merged commit 6367571 into develop Oct 3, 2024
22 of 24 checks passed
@causten causten deleted the rnnt_debugging branch October 3, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants