-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
driver verify bisect #3460
base: develop
Are you sure you want to change the base?
driver verify bisect #3460
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3460 +/- ##
===========================================
- Coverage 92.05% 92.03% -0.02%
===========================================
Files 506 506
Lines 20837 20878 +41
===========================================
+ Hits 19181 19215 +34
- Misses 1656 1663 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/driver/verify.cpp
Outdated
|
||
std::cout << "Bisect Verify steps: " << right << std::endl; | ||
while (left <= right) { | ||
std::size_t mid = left + (right - left) / 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to skip the instructions that are const foldable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can probably create a vector to do the mapping:
std::vector<std::size_t> trim_map;
std::size_t i = 0;
for(const auto& ins:*mm)
{
if(not ins.can_eval())
trim_map.push_back(i);
i++;
}
Then do the bisection over trim_map
and then use it to get the actual trim value: verify_bisect(p, trim_map[mid], t, options, vo, inputs, tols)
.
else | ||
{ | ||
children = v.get_children(ins); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me revert these changes to the dominator since its not needed anymore.
This build is not recommended to merge 🔴 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
No description provided.