Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Op Builder API #3328

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Introduce Op Builder API #3328

wants to merge 3 commits into from

Conversation

mirza-halilcevic
Copy link
Collaborator

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 98.67725% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.24%. Comparing base (19d8b1b) to head (90f3b3b).
Report is 42 commits behind head on develop.

Files Patch % Lines
src/op/builder/einsum.cpp 98.91% 3 Missing ⚠️
src/op/builder/op_builder.cpp 80.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3328   +/-   ##
========================================
  Coverage    92.24%   92.24%           
========================================
  Files          495      500    +5     
  Lines        19849    19889   +40     
========================================
+ Hits         18309    18347   +38     
- Misses        1540     1542    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CharlieL7
Copy link
Collaborator

What's the status of this PR? Should anything be reviewed at this stage or a meeting held?

@mirza-halilcevic
Copy link
Collaborator Author

What's the status of this PR? Should anything be reviewed at this stage or a meeting held?

Work on this was put on hold due to higher-priority tasks on CK. However, this can be reviewed as is. What remains is the implementation of builders for the remaining operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Common API - Op Builder API
3 participants