Fixes behaviour of get_stations() returning query objects #99
Conversation
ThomasLecocq
changed the title
|
It's not really a bug, indeed, this is better like that. I will just check that this refactor doens't affect any other parts of the code (normally not). |
|
Oh, okay. Due to that dualism in types being returned from that method, the calculate_stretching was failing. With that fix, it works. Edit: |
|
Okay, since most of the cases, this method returns a querry, maybe it should be better to make it returning the querry in all cases? And just converting the output according to needs. I'm sorry I'm whining at this moment a bit, but returning different things from one method will definitely produce bugs in the future. |
Now, instead of returning only lists or mix of lists and querries, method get_stations() returns querries. All methods requiring list was changed to obtain it.
… get_station_bugix
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=======================================
Coverage 74.28% 74.28%
=======================================
Files 17 17
Lines 2477 2477
=======================================
Hits 1840 1840
Misses 637 637
Continue to review full report at Codecov.
|
This is wrong, it only returns a query when the |
|
Okay. I will continue to dig into that bug and make this function return list. |
get_station() was returning query objects instead of list of station. The fix is simple, but why there were a workaround in the test? :(