get_results throws exception when dir doesn't exist #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change affects get_results method in API. It also adds test method for checking that throwing
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
- Coverage 73.44% 73.43% -0.01%
==========================================
Files 17 17
Lines 2478 2481 +3
==========================================
+ Hits 1820 1822 +2
- Misses 658 659 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I create a separate pull request to extract this feature from PR#101.
This just checks if directory created out from provided station names exists. In case it doesn't, an exception is being thrown.
There is also added a test for that exception throwing.