Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Disable http client metrics, they bloat metrics #8

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lolepezy
Copy link
Contributor

@lolepezy lolepezy commented Jun 22, 2023

It creates new tag value for every new snapshot URL so it bloating metrics

http_client_requests_seconds_max{client_name="rrdp.ripe.net",error="none",exception="none",method="GET",outcome="SUCCESS",status="200",uri="/f351ea8a-62f5-4138-ad36-e93aa102fa88/39483/snapshot-ffd032beb276ee833af3ce693f506bbbc7b57dac71b946964dad8f27612baa57.xml",} 0.0
http_client_requests_seconds_max{client_name="rrdp.ripe.net",error="none",exception="none",method="GET",outcome="SUCCESS",status="200",uri="/f351ea8a-62f5-4138-ad36-e93aa102fa88/39360/snapshot-3859b8edde4bc06ee33cae2ab52ccaecc1fd1ac59e56b9b9448b6e8d85510e36.xml",} 0.0
http_client_requests_seconds_max{client_name="rrdp.ripe.net",error="none",exception="none",method="GET",outcome="SUCCESS",status="200",uri="/f351ea8a-62f5-4138-ad36-e93aa102fa88/39426/snapshot-b70b30ed711f81bb84f1fe62ac728d280acfa3c2432640bc8187b4ef81020af6.xml",} 0.0

So I replaced it with a manual gauge

@lolepezy lolepezy requested review from ties and bjpbakker June 22, 2023 13:19
@lolepezy lolepezy changed the title Disable http client metrics, they bloat metrics WIP: Disable http client metrics, they bloat metrics Jun 22, 2023
@ties
Copy link
Member

ties commented Jun 22, 2023

I think rpki monitoring has a neat solution for this, think it is a spring bean though. We can still have the metrics but not have the url as "low cardinality metric"

@lolepezy lolepezy mentioned this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants