WIP: Code for generating ecdsa secp256r1 objects #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ties
commented
Sep 1, 2023
ties
commented
- I have updated the changelog in README.md
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| public KeyPair generate() { | ||
| try { | ||
| final KeyPairGenerator generator = KeyPairGenerator.getInstance(ALGORITHM, provider); |
Check failure
Code scanning / CodeQL
Use of a potentially broken or risky cryptographic algorithm High
|
|
||
| private static final PregeneratedEcKeyPairFactory INSTANCE = new PregeneratedEcKeyPairFactory("SunEC"); | ||
|
|
||
| private static final char[] PASSPHRASE = "passphrase".toCharArray(); |
Check failure
Code scanning / CodeQL
Hard-coded credential in API call Critical test
While profile-15 contains text for implicit tags, this was a mistake and all other sample objects have explicit tags. This was changed later.
| @@ -108,6 +110,14 @@ | |||
| Validate.notNull(resources, "no resources"); | |||
| Validate.isTrue(!resources.isEmpty(), "empty resources"); | |||
| } | |||
|
|
|||
| if (builderHelper.getSigningKeyPair().getPublic().getAlgorithm() == "EC") { | |||
Check warning
Code scanning / CodeQL
Reference equality test on strings Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.