Fido2 update tests #20876
Open
Fido2 update tests #20876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ollrogge
requested review from
leandrolanzieri,
aabadie and
MichelRottleuthner
as code owners
github-actions
bot
added
Area: tests
Ollrogge
force-pushed
the
fido2_update_tests
branch
from
05749af
to
f68f19a
Compare
benpicco
added
the
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Update the fido2 test package to the latest version. Also fix a small bug in the GetAssertion & GetNextAssertion behavior which became apparent because a new test failed.
I ran all tests using the nrf5284dk and reached 100% with the ctap fix.
Testing procedure
/sys/sys/fido2_ctap