Add clean_data_cache_all and stabilize Raspberry Pi 4B SMP Support #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit add clean_data_cache_all into common/src/cpu.rs This function flush each Level's data caches by set/way. Signed-off-by: Manami Mori <[email protected]>
garasubo
reviewed
Sep 3, 2023
|
|
||
| for set in 0..num_sets { | ||
| for way in 0..associativity { | ||
| /* C5.3.13 DC CISW, Data or unified Cache line Clean and Invalidate by Set/Way (ARM DDI 0487G.a ID011921) |
There was a problem hiding this comment.
Nit: This information looks a little bit old. The latest manual version is ARM DDI 0487J.a (ID042523), and the section number of DC CISW is C5.3.15.
garasubo
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
clean_data_cache_alltocommon/src/cpu.rs.This function will flush the data caches of each level by set/way.
After writing boot information to memory, flush data cache and synchronise memory data by calling
clean_data_cache_all.This PR seems to fix #10 .