Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix back_and_forth in witness mode #15

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

zoedberg
Copy link
Collaborator

Since there is not yet a smart input selection when using the pay method, if we run the back_and_forth test in witness mode we encounter the following error

called `Result::unwrap()` on an `Err` value: Composition(Construction(NoFundsForFee { input_value: Sats(1000), output_value: Sats(1000), fee: Sats(400) }))

this error has already been reported in RGB-WG/rgb#113

For now this PR changes the sat amounts at each loop in a way that both wallets always have enough sats to pay for fees (to avoid NoFundsForFee) and have a change output (to avoid NoBlankOrChange).

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6012371

@dr-orlovsky dr-orlovsky merged commit 5b6f29c into RGB-WG:master Sep 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants