Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 is coming #3

Open
14 of 15 tasks
REJack opened this issue Jan 28, 2017 · 3 comments
Open
14 of 15 tasks

v1.0.0 is coming #3

REJack opened this issue Jan 28, 2017 · 3 comments
Labels

Comments

@REJack
Copy link
Owner

REJack commented Jan 28, 2017

Hey together,

I've pushed & released a new version today (0.9.3) with a asset function.

Now I want to finish codeigniter-twiggy, my ideas are:

  • add meta & asset array to config for something like main or global meta's/assets
  • add a bunch of default allowed functions from some CI3 helpers
    • abilty to auto register user_defined_functions (added in v0.9.7)
  • Twig v2 compatibility (added in v0.9.7)
  • adapt CI3 erros to twiggy
  • add abilty to add safe functions to twiggy
  • enhance assets function
    • add abilty to create group assets (e.g. $this->assets('<TYPE>', '<FILENAME>', '<GROUP>');)
    • create assets helper to render group assets
  • create optional MY_Controller for auto theme/layout loading with errors (like CakePHP does)
  • add twiggy_helper.txt from waptik
  • Overhaul gh-pages & docs
    • change github page
    • create a complete new documentation over GitBook & remove phpDoc infos
      • new Docs online here
  • change codestyle based on CI3's PHP Style Guide
  • PHPunit Tests over Travis-CI & CodeCoverage over Coveralls

If anyone have a idea for some nice functions feel free to comment on this issue.

regards REJack

@REJack REJack added the news label Jan 28, 2017
@waptik
Copy link

waptik commented Jun 21, 2017

Hi there, thanks for the update on the project.
I'd like to suggest some helper to be used inside twig template. Say I have called $this->twiggy->asset('script', 'home', 'home.js'); in my controller, it'll be good to have a helper to call the defined asset as such in the desired template : {{ asset('home') }}
I attached a new version of the twiggy helper file. The functions in it are only for controller usage . With them, no need to use $this->twiggy-> to set theme, template, layout, asset, meta data etc.
Hope it helps you and the others.
twiggy_helper.txt

@REJack
Copy link
Owner Author

REJack commented Sep 2, 2017

Thanks for this nice helper, any help & suggestion is welcome.

  1. (helper inside Twig) There is already {{meta}} {{asset}} available. I'm planing to add asset_footer too.
  2. I'll add this helper, its nice but I need to rewrite them from camelCase to snake_case. (camelCase not allowed in CI3's PHP Style Guide 😄)

@waptik
Copy link

waptik commented Sep 3, 2017

You're very welcome bro.
Well the asset and meta helpers you have can only be used as data variables only but not as functions. I think I have something like that. So whenever possible I'll test it first if it works and then ask for a pull.
Don't worry about the help & suggestions, I'll do that when I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants