Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor prof.to.features #84

Merged
merged 166 commits into from
Aug 17, 2022
Merged

Refactor prof.to.features #84

merged 166 commits into from
Aug 17, 2022

Conversation

maximskorik
Copy link
Member

@maximskorik maximskorik commented Aug 2, 2022 •
edited by hechth
Loading

TODO:

Summary:

Testing:

test-prof.to.features, test-unsupervised, and test-hybrid all passed in devcontainer.

Closes #76

wverastegui and others added 30 commits July 29, 2022 11:18
@wverastegui
setup remote
b006c19
@wverastegui
Update
b099d9e
@hechth
extracted functions into top level
ae0be7d
@wverastegui
Refactoring
e573714
@hechth
renamed and extracted variables
91746c2
Started adding documentation and reworked base.curve variable
70152c6
@maximskorik
add gaussian test cases
7e93cb6
@maximskorik
mark a bug
c956608
@maximskorik
change variable
fef6835
@maximskorik
remove nested conditionals
49fa52a
@maximskorik
simplify argument checks
10daab0
@maximskorik
reformat conditionals
af430cf
@maximskorik
change feature-matrix var name
2386d55
@maximskorik
change var name
72238de
@maximskorik
wrap input validation
14fac74
@maximskorik
wrap bandwidth preprocessing
678a330
@maximskorik
add colnames; slice dataframes by colnames
d07b3ae
@maximskorik
add more slicing by colname
55ff10c
@maximskorik
add slicing this.features by colnames
416df7f
@maximskorik
rename nrowa
f70a310
@maximskorik
reformat oneline conditionals
573be8d
@maximskorik
remove redundant assignment
a4a5f97
@maximskorik
rename undescriptive variable
5390232
@maximskorik
remove fallacious conditional (it's always FALSE)
91c82dc
@hechth
Removed compute base curve function
60119d1
@maximskorik
remove commented out code
091ca25
@hechth
Removed parallel code section from test
572ebaa
@hechth
Renamed all.times to delta_rt which is the actual content of the vari…
145e31f 
…able and renamed matching function
@maximskorik
wrap gaussian peak computing
bc9b0c9
@maximskorik
simplify iterable
eb24305
@maximskorik
Copy link
Member Author

maximskorik commented Aug 12, 2022 •
edited
Loading

Waiting for #92 for the hybrid test to pass.

@maximskorik maximskorik marked this pull request as ready for review August 12, 2022 14:52
@hechth hechth merged commit b6ca6ee into RECETOX:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zargham-ahmad zargham-ahmad zargham-ahmad left review comments

@hechth hechth hechth left review comments

Assignees
No one assigned
Labels
refactoring Refactor existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor prof.to.features
4 participants
@maximskorik @hechth @zargham-ahmad @wverastegui