Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: prof.to.features fails when peak shape is Gaussian #85

Open
2 tasks
maximskorik opened this issue Aug 3, 2022 · 1 comment
Open
2 tasks

bug: prof.to.features fails when peak shape is Gaussian #85

maximskorik opened this issue Aug 3, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@maximskorik
Copy link
Member

maximskorik commented Aug 3, 2022

Description

prof.to.features fails when executed on mbr_test0_cdf.Rds data with shape.model=Gaussian.

The error occurs at the runtime of normix() function which tries to access a value out of range during iteration:

for (m in 1:l) {
   w[m, ] <- dnorm(x, mean = miu[m], sd = sigma[m]) * sc[m] / all.w
}

There are cases when l(lowercase L) is 0. In such cases iteration goes from 1 to 0 but the indexing in R starts at 1.

Steps:

  • run the prof.to.features function with the peak shape parameter set to Gaussian by adding a test case which reproduces this error
  • use different datasets from the input to see which behaviours occur
@maximskorik maximskorik added the bug Something isn't working label Aug 3, 2022
@maximskorik maximskorik changed the title bug: prof.to.features fails with Gaussian shape bug: prof.to.features fails when peak shape is Gaussian Aug 3, 2022
@hechth hechth moved this to 📋 Backlog in recetox-aplcms Prototype Dec 13, 2022
@hechth hechth added the wontfix This will not be worked on label Mar 29, 2023
@hechth hechth removed the wontfix This will not be worked on label Apr 18, 2024
@hechth
Copy link
Member

hechth commented Apr 18, 2024

Lets first have a look and try some simpler solutions before spending too much time on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants