Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tool: matchms_subsetting_tool #437

Merged
merged 7 commits into from
Nov 22, 2023
Merged

Conversation

zargham-ahmad
Copy link
Collaborator

@zargham-ahmad zargham-ahmad commented Nov 20, 2023

This PR includes the following:

TODO

closes #431

@zargham-ahmad zargham-ahmad requested a review from hechth November 20, 2023 16:45
Copy link
Member

@hechth hechth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only some small changes regarding the test and naming of the tool

tools/matchms/matchms_subsetting_tool.xml Outdated Show resolved Hide resolved
tools/matchms/matchms_subsetting_tool.xml Outdated Show resolved Hide resolved
tools/matchms/matchms_subsetting_tool.xml Outdated Show resolved Hide resolved
@zargham-ahmad zargham-ahmad marked this pull request as ready for review November 22, 2023 13:44
@hechth hechth merged commit a056562 into RECETOX:master Nov 22, 2023
13 checks passed
@zargham-ahmad zargham-ahmad deleted the issue431 branch January 24, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

matchms spectral library subsetting tool
2 participants