Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

un-commented and fixed test case #50

Merged
merged 2 commits into from
Sep 6, 2024
Merged

un-commented and fixed test case #50

merged 2 commits into from
Sep 6, 2024

Conversation

hechth
Copy link
Member

@hechth hechth commented Sep 6, 2024

Closes #49

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (eb3168d) to head (5b98a41).
Report is 84 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   89.76%   89.84%   +0.08%     
==========================================
  Files           8        9       +1     
  Lines        3839     3910      +71     
==========================================
+ Hits         3446     3513      +67     
- Misses        393      397       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@KristinaGomoryova KristinaGomoryova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing the non-parametrized test if mode=TRUE if parametrized covers both cases, otherwise looks good :-)

tests/testthat/test-findRecalSeries.R Show resolved Hide resolved
@hechth hechth merged commit 8040f8c into master Sep 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

findRecalSeries: add a parametrized test for the find_final_series() function
2 participants