Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed SNplot duplicate #27

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Removed SNplot duplicate #27

merged 5 commits into from
Dec 13, 2023

Conversation

hechth
Copy link
Member

@hechth hechth commented Dec 12, 2023

Closes #8

Removed the SNplot function from HistNoise and added a test that creates the plot.
Also ran devtools::document to create the NAMESPACE file automatically.

Copy link

@zargham-ahmad zargham-ahmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me!

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ccdaa3c) 8.37% compared to head (ec66c0f) 8.62%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #27      +/-   ##
=========================================
+ Coverage    8.37%   8.62%   +0.24%     
=========================================
  Files          10      10              
  Lines        4095    4095              
=========================================
+ Hits          343     353      +10     
+ Misses       3752    3742      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hechth hechth merged commit beb874a into master Dec 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplciated SNplot function
3 participants