Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all versions of Android #156

Closed

Conversation

AbdurazaaqMohammed
Copy link

With some minor changes support for all Android versions can be established for use of APKEditor in an Android application with no further modification of APKEditor necessary. I did test and conclude that the output of all 6 main functions of the tool remains consistent with before. I will attempt to make similar modifications to ARSCLib to make it compatible in the same fashion.

@REAndroid
Copy link
Owner

Thank you.

Seems like you found some problems on ArraySort that prevent you from using List.sort, can you trace what is the conflict with android os ? I prefer not to use java.util.Arrays for multiple reasons.

use com.reandroid.utils.collection.ArraySort instead of Arrays.sort
@AbdurazaaqMohammed
Copy link
Author

Call requires API level 24 (current min is 1): java.util.List#sort

No problem with ArraySort, I just forgot about it, I replaced Arrays with ArraySort and it works fine

@REAndroid
Copy link
Owner

So why not use CollectionUtil#sort ?

@AbdurazaaqMohammed
Copy link
Author

But CollectionUtil.sort calls List.sort

qtaw-366224408

@AbdurazaaqMohammed
Copy link
Author

Well I forgot about java.util.Collections.sort, is that method okay?

@REAndroid
Copy link
Owner

I don't know what you want me to do with your picture

@AbdurazaaqMohammed
Copy link
Author

Nothing, I thought it was funny, sorry for wasting your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants