-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make full use of UseCase class #102
Merged
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
bb8fcca
Add dates input options to usecase
Bachibouzouk f375fc3
Move calc_peak_time_range as method of usecase
Bachibouzouk d1d2123
Connect User instances to a potential usecase
Bachibouzouk 62c5e0d
Update generate_daily_load_profiles
Bachibouzouk 8b0148c
Adapt input files
Bachibouzouk e9824fd
Remove unused code
Bachibouzouk 6957148
Change attribute name
Bachibouzouk c11d510
Add one example of rewritten notebook
Bachibouzouk 6272db7
Modify run_uscase and cli modules
Bachibouzouk d33f264
Define num_days for User class
Bachibouzouk 3d3a5b4
Fix failing test
Bachibouzouk 68cd804
Enable python file to be run by ramp cli
Bachibouzouk 7106134
Move code from Run postprocess to UseCase methods
Bachibouzouk b2da25e
Adapt README
Bachibouzouk d40836c
Add a test to make sure the .ipynb file in documentation run
Bachibouzouk f993703
Make get_day_type function accept iso format date string as input
Bachibouzouk f0ce520
Provide getter and setter for date input of UseCase
Bachibouzouk 7155317
By default expect 366 days for power timeseries input
Bachibouzouk a957c1b
Make peak_enlarge an attribute of the UseCase
Bachibouzouk 733de35
Fix parallel processing
Bachibouzouk 7a89100
Add a property to check if UseCase was already initialized
Bachibouzouk b51c917
Make daily_profile method callable with default values
Bachibouzouk 4ca0060
Manage options to build a date range depending on user inputs
Bachibouzouk 1991528
Fix and lint jupter notebooks
Bachibouzouk fd8b22d
Fix conversion from .py to .xlsx
Bachibouzouk 7eb6abb
Fix failing tests
Bachibouzouk b09be99
Fix test requiring 365 days in a year
Bachibouzouk 45d4b5c
Comment out a failing test
Bachibouzouk 1939c8c
Lint test file
Bachibouzouk 7c3199c
Add nbformat to test requirements
Bachibouzouk 69738f4
Correct typo in core.py
FLomb 8c4f97b
Update, fix and refine jupyter notebooks
FLomb fbbc8f2
Update README file
FLomb 2f67728
Update test requirements
Bachibouzouk fee9a81
Add local ramp package to test requirements
Bachibouzouk f4e4abd
Fix twine check errors
Bachibouzouk 50b5d38
Update .rst files based on jupyter notebooks examples
Bachibouzouk c4e3ca0
Improve cli help text and lint jupyter example notebooks
Bachibouzouk 67231ed
Updaing the API docs for UseCase
mohammadamint 3bad531
Update api_references.rst
mohammadamint 3791f67
Update readme to showcase UseCase
FLomb 0dd2ad8
Update docstrings
Bachibouzouk 240ce33
Fix docs warnings
Bachibouzouk f8c4adb
Add missing images for the docs
Bachibouzouk 7189443
Update changelog
Bachibouzouk f78dee4
Minor typo fixes in CHANGELOG.md
FLomb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A problem I see in the
README.rst
file is that we import theUseCase
but never use it. We just run the profiles for oneUser
, which is not what one typically wants to do. We should show how to addUsers
to aUseCase
and how to run via theUseCase
class.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, I just translated the existing example but we should also showcase the
UseCase
more