Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.4.2 #100

Closed
wants to merge 60 commits into from
Closed

Release v0.4.2 #100

wants to merge 60 commits into from

Conversation

Bachibouzouk
Copy link
Collaborator

@Bachibouzouk Bachibouzouk commented Nov 8, 2023

Remaining TODO in this PR:

  • update changelog
  • update AUTHORS
  • bump version number
  • once it is merged into main do not delete the branch but merge it into development

mohammadamint and others added 30 commits March 1, 2023 11:58
The old docs/input_parameters.md file was not included in the document.
The new file with rst format is added to the documentations in:
docs/source/input_parameters.rst
Addine the new input_parameters to index.rst and removing the old file.
pypi test release on push for main branch
I have made minor edits to correct small typos or improve clarity
Mimimum required readthedocs config file
…ommand-cli

Hotfix/hidden result files command cli
Fixed a few small spelling errors.
FLomb and others added 13 commits November 6, 2023 14:23
Fixed the mismatch between a title length and the underlying line of "~" symbols, as requested by the reviewers
This fixes the problem currently blocking PR #96
updating the secrets for API Token for the automatic test release of
software after Pushes and PRs to developemnt and main
using kebab-case for skip-exisiting and repository-url
solving the test.pypi release issue #96
The new features added will allow the user to perform some data analysis
and visualization routines:

changes
------
*. ramp/post_process/post_process.py

- the class Plot is the main class carrying on the plotting and data
analysis functionalities with custom APIs providing access to some
pd.DataFrame features also easy to plot functions conencting to plotly
and matplotlibe methods.

- different plotting classes that include a specific plot type
  visualiztion using two different engines (plotly & matplotlib)

*. ramp.__init__.py
- adding the Plot class to the init.

documentation
-------------
- the functions API docuemntation is added to the API documentaiton
- A full example titled "Plot class" is added to the example gallery
  describing the full potential of the new functionalities
- Improving the Plot class docstring
- Improving the error handling with invalid inputs by user regarding the
  file extensions and plot engine
- Improving the readability of the plotting scripts by merging the plot
  classes into Plot methods
Plot class for ramp visualization and data analysis routines (isse #63)
@mohammadamint
Copy link
Collaborator

mohammadamint commented Nov 8, 2023

Remaining TODO in this PR:

  • update changelog
  • update AUTHORS
  • bump version number
  • once it is merged into main do not delete the branch but merge it into development

@Bachibouzouk I would add black and maybe isort to the list!

@Bachibouzouk
Copy link
Collaborator Author

Bachibouzouk commented Nov 8, 2023

@Bachibouzouk I would add black and maybe isort to the list!

Then we should do this in separate PRs and then I will rebase the release branch on the dev branch once this has been merged. Normally the release branch should not have too much "work" done into it, only release related stuff: because for black one could apply black and setup a github action which rejects not black linted code. For that we need to pin a black version in the requirements. I would not consider those "release related" commits.

Edit --> I did open a PR in #101

@FLomb
Copy link
Contributor

FLomb commented Nov 9, 2023

I think it would be great if we could also quickly address issue #83 as part of the new release since that is blocking several old-school users, while it seems that we have found a relatively easy fix in the related GitHub thread. I can implement myself the proposed fix if needed, but it would make more sense for @Bachibouzouk to set up a PR since he proposed such a fix.

@Bachibouzouk
Copy link
Collaborator Author

I can implement myself the proposed fix if needed, but it would make more sense for @Bachibouzouk to set up a PR since he proposed such a fix.

Gladly, I just cannot promise I'll to do it by tomorrow :) I will do it after the lint PR is accepted so I can work with linted code :)

@FLomb
Copy link
Contributor

FLomb commented Nov 9, 2023

I can implement myself the proposed fix if needed, but it would make more sense for @Bachibouzouk to set up a PR since he proposed such a fix.

Gladly, I just cannot promise I'll to do it by tomorrow :) I will do it after the lint PR is accepted so I can work with linted code :)

Sure, no hurry! (: Thanks

@FLomb FLomb changed the title Release v0.4.2 Release v0.5.0 Dec 5, 2023
@FLomb
Copy link
Contributor

FLomb commented Dec 5, 2023

Having finalised PR #102 , we should proceed with the new code release. This was originally meant to be v0.4.2, but we agreed in the last developers meeting to name it instead v0.5.0.

So, I think that what needs to happen here is to update the changelog to call this v0.5.0. Are there any other missing things?

The Zenodo publication of the new release has been automated via the Zenodo web interface, so it will automatically happen.

@FLomb
Copy link
Contributor

FLomb commented Dec 5, 2023

Having finalised PR #102 , we should proceed with the new code release. This was originally meant to be v0.4.2, but we agreed in the last developers meeting to name it instead v0.5.0.

So, I think that what needs to happen here is to update the changelog to call this v0.5.0. Are there any other missing things?

The Zenodo publication of the new release has been automated via the Zenodo web interface, so it will automatically happen.

I guess another thing is indeed to update the AUTHORS file to add those who will be part of the JOSS paper but are not yet mentioned there

@Bachibouzouk
Copy link
Collaborator Author

So, I think that what needs to happen here is to update the changelog to call this v0.5.0. Are there any other missing things?

I would rather create a new branch release/0.5.0 from development, close this PR and start a new one :)

What needs to be done is already listed in this PR's description

@Bachibouzouk Bachibouzouk changed the title Release v0.5.0 Release v0.4.2 Dec 5, 2023
@Bachibouzouk
Copy link
Collaborator Author

Taken cared of in #106

@Bachibouzouk Bachibouzouk deleted the release/0.4.2 branch December 6, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants