-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added image registry to radar charts #310
base: main
Are you sure you want to change the base?
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
8547974
to
ca2e1a3
Compare
@@ -1,8 +1,8 @@ | |||
apiVersion: v2 | |||
appVersion: "1.0" | |||
appVersion: "RELEASE.2024-11-21T17-21-54Z" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pvannierop I remember we had an issue with s3-proxy application version in the helm chart, I don't remember what exactly it was. Do you think that issue will be present here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keyvaann I do not recall this issue to be honest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was reverted in this commit, 5ac54d6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this a nice change that will:
- Allow more extended configuration of the docker image repository (while at the same time clean up the codebase)
- Allow for standardization between radarbase helm charts by using a bitnami common chart.
However, I do have a comment/suggestion regarding the standardization. I notice that for all affected charts there is a repeated section added in the _helpers.tpl file such ad this:
{{/*
Return the proper image name
*/}}
{{- define "management-portal.image" -}}
{{ include "common.images.image" (dict "imageRoot" .Values.image "global" .Values.global "chart" .Chart ) }}
{{- end -}}
{{/*
Return the proper Docker Image Registry Secret Names
*/}}
{{- define "management-portal.imagePullSecrets" -}}
{{- include "common.images.pullSecrets" (dict "images" (list .Values.image) "global" .Values.global) -}}
{{- end -}}
Would it not be a good opportunity to define this helper in the common chart? If needed we can wrap the bitnami common chart to add shared RADAR-base functionality?
Repeated _helper functions are also part of the bitnami chart structure: |
The goal of this PR is to allow image registry to be configured in radar helm charts, which should make it easier to define alternative registries that can act as an pull through cache.
In this process a few things have been changed:
image.pullSecrets
instead ofimagePullSecrets
to define name of the secrets containing image registry credentials.