Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.2 #333

Merged
merged 270 commits into from
Jan 22, 2025
Merged

Release 1.2 #333

merged 270 commits into from
Jan 22, 2025

Conversation

keyvaann
Copy link
Collaborator

@keyvaann keyvaann commented Oct 9, 2024

We can use this branch to make the new release.

keyvaann and others added 30 commits May 2, 2024 12:58
@keyvaann
Update velero version to fix BackfOffLimit error
7f29015 
Implement RADAR-base/radar-helm-charts#117
@keyvaann
bugfix: BackOffLimitExceeded GLIBC not found Velero
b7aedaf
@mpgxvii
Update MP, appserver, rest-backend, upload-backend charts for egress …
029637c 
…config fixes
@keyvaann
Merge pull request #255 from RADAR-base/push-endpoint-fix
74d9914 
Fixed radar-push-endpoint servicemonitor
@keyvaann
Merge branch 'dev' into upgrade_catalogserver_chart
6e01599 
* dev:
  bugfix: BackOffLimitExceeded GLIBC not found Velero
  Update velero version to fix BackfOffLimit error
  Fixed radar-push-endpoint servicemonitor
@keyvaann
Merge pull request #254 from RADAR-base/upgrade_catalogserver_chart
01997a0 
Upgrade catalog server to chart 0.5.2
@keyvaann
Merge branch 'dev' into fix-egress
a3f6bfc 
* dev:
  bugfix: BackOffLimitExceeded GLIBC not found Velero
  Update velero version to fix BackfOffLimit error
  Fixed radar-push-endpoint servicemonitor
  Upgrade catalog server to chart 0.5.2
@pvannierop
Add version scan GitHub action
1c86df5
@pvannierop
Make version_scan executable
e73955e
@pvannierop
Run GitHub Action on Main branch only
c0347fb
@mpgxvii
Merge pull request #260 from RADAR-base/fix-egress
601e42c 
Update chart versions for egress config fixes
@keyvaann
Added CONTRIBUTING.md
0e50e64
@keyvaann
First draft of CONTRIBUTING.md
18ca286
@keyvaann
Added information on adding a helmfile
49158c2
@keyvaann
Added CI information to CONTRIBUTING.md
042abc7
@keyvaann
Improved README.md
ee6f72f
@keyvaann
Enable MP keystore by default
e4a348f
@keyvaann
Improve README.md
28fde45
@keyvaann
Added links to sops and helm-secrets in README.md
313c125
@keyvaann
Fix spelling issues on CONTRIBUTING.md
7c2fd1a
@keyvaann
Merge pull request #263 from RADAR-base/improve-docs
9273f13 
Improve docs
@blootsvoets @pvannierop
Add Ory Kratos service
3f83907
@pvannierop
Add <<: *logFailedRelease
d69071b 
PR feedback Keyvan.
@pvannierop
Enable Ory-Kratos by default
3730766 
PR feedback Keyvan.
@pvannierop
Allow configuration of SMTP port
0e124e3 
PR feedback Keyvan.
@pvannierop
Allow configuration of database name
ecf2478 
PR feedback Keyvan.
@pvannierop
Fix indentation of comment
c5e1528 
PR feedback Keyvan.
@pvannierop
Fix chart version and repository
35cc4ca
@pvannierop
Move definition of SMTP 'from' field to base.yaml
ba513d5
@pvannierop
Remove field that are defined as defaults in helm chart
e071e5b
mpgxvii
mpgxvii reviewed Nov 17, 2024
View reviewed changes
etc/cp-schema-registry/values.yaml
@@ -19,7 +17,6 @@ resources:
ingress:
enabled: true
annotations:
kubernetes.io/ingress.class: nginx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to replace this with ingressClassName: "nginx"?

Copy link
Collaborator Author

@keyvaann keyvaann Nov 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but it is in the latest version of the schema registry helm chart so there shouldn't be an issue.
RADAR-base/cp-helm-charts@44e0148

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay thank you! Is it 0.3.2?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@Hsankesara Hsankesara mentioned this pull request Dec 4, 2024
Merged
@keyvaann
Copy link
Collaborator Author

keyvaann commented Jan 13, 2025 •
edited
Loading

@pvannierop @mpgxvii @yatharthranjan
I think it's time to merge this PR and I need approval to make the release. Please let me know if you want to make further adjustments.

yatharthranjan
yatharthranjan approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM.

It would be nice if @mpgxvii and @baixiac can review too.

I assume the release version would be 1.2.0, not 1.2 ?

baixiac
baixiac reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@baixiac baixiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Just wonder if it's worth mentioning this release will continue supporting K8s 1.29 and 1.28. Also, can the README link back to RADAR-K8s-Infrastructure as an alternative for users preferring a cloud provider over k3s?

keyvaann
keyvaann commented Jan 17, 2025
View reviewed changes
etc/base.yaml Outdated Show resolved Hide resolved
keyvaann
keyvaann commented Jan 17, 2025
View reviewed changes
etc/base.yaml Outdated Show resolved Hide resolved
@keyvaann
Copy link
Collaborator Author

Nice work. Just wonder if it's worth mentioning this release will continue supporting K8s 1.29 and 1.28. Also, can the README link back to RADAR-K8s-Infrastructure as an alternative for users preferring a cloud provider over k3s?

I did add the note about RADAR-K8s-Infrastructure, I think mentioning older versions of K8S isn't needed as I don't think there will be new installations that are using it.

@keyvaann keyvaann merged commit ef5ae91 into main Jan 22, 2025
3 checks passed
@keyvaann keyvaann deleted the release-1.2 branch January 23, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baixiac baixiac baixiac left review comments

@mpgxvii mpgxvii mpgxvii left review comments

@yatharthranjan yatharthranjan yatharthranjan approved these changes

@pvannierop pvannierop Awaiting requested review from pvannierop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@keyvaann @pvannierop @yatharthranjan @mpgxvii @baixiac @blootsvoets @Bdegraaf1234 @ewelinagr