Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom OOB timer per level scope #907

Merged
merged 4 commits into from
Jan 1, 2025

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Nov 24, 2024

This PR on its own will not do anything, this is a feature support for mods or custom gamemodes that allows them to override the amount of time players can stay in the Out of Bounds areas.

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 24, 2024
@Zanieon Zanieon self-assigned this Nov 27, 2024
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, could use some supporting documentation though? (Different PR)

@Zanieon
Copy link
Contributor Author

Zanieon commented Dec 16, 2024

Code looks good, could use some supporting documentation though? (Different PR)

Sure thing, telling about the utility of this won't be a hard task.

@Zanieon Zanieon added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Dec 16, 2024
Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.
I tested proposed change by running script level.customOOBTimer = 500.0 in a private match, and got expected result:

image

@Zanieon Zanieon added READY TO MERGE This mergeable right now and removed almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Jan 1, 2025
@GeckoEidechse GeckoEidechse merged commit 3a823af into R2Northstar:main Jan 1, 2025
3 checks passed
@Zanieon Zanieon deleted the level_custom_OOB_timer branch January 1, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now
Projects
Status: No status
Status: Zanieon Doing
Development

Successfully merging this pull request may close these issues.

4 participants