-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore missing faction dialogue for Titan Meter buildup #876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, didn't test though
Northstar.CustomServers/mod/scripts/vscripts/earn_meter/sv_earn_meter_mp.gnut
Outdated
Show resolved
Hide resolved
Can confirm that this does add the missing voicelines. Just one small issue though: Before: After: |
Actually, i guess im not sure if i would call that an issue. That makes it match |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked over it with @Zanieon in vc together and the changes implemented appear to be correct.
Not a big fan of the way the state tracking is done but it matches existing logic so it's fine ig.
Currently we have a missing characteristic from the Titan Meter that the faction leader will speak about the pilot's titan being almost ready when it reaches around 75%, and then immediately telling their Titan is ready soon as it hits 100%, this is my attempt to bring that behavior back.