Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change gun game score limit setting #735

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Change gun game score limit setting #735

merged 2 commits into from
Oct 28, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

Closes #308

Gun game was never set up to properly use the playlistvars for setting guns, and relied on playlistvaroverrides to set the score limit, this caused the change to persist to other modes

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 5, 2023
@GeckoEidechse
Copy link
Member

What's the best way to test this?

@ASpoonPlaysGames
Copy link
Contributor Author

What's the best way to test this?

Try and replicate the linked issue

Jan200101
Jan200101 approved these changes Oct 17, 2023
View reviewed changes
Copy link

@Jan200101 Jan200101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and does what it says on the tin. Other game modes no longer experience sideeffects from gungame.

Code simply removes previous workarounds or hacks to set the score correctly that are no longer needed.

@Jan200101 Jan200101 added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 17, 2023
@GeckoEidechse
Copy link
Member

Merging based on reviews.

@GeckoEidechse GeckoEidechse merged commit 82f8712 into R2Northstar:main Oct 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jan200101 Jan200101 Jan200101 approved these changes

Assignees
No one assigned
Labels
READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Playing Gun Game sets score limit to 28 for all subsequent matches
3 participants
@ASpoonPlaysGames @GeckoEidechse @Jan200101