Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock paid items with progression enabled #726

Merged
merged 11 commits into from
Oct 11, 2023

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Sep 29, 2023

When turning on progression now, items that should be purchased from the store will remain unlocked, the reason is that i noticed the majority of players don't want to enable progression solely because the store camos in their Titans/Weapons, or using Prime Titans entirely, the developer profile banners and icon patches exposed from the DevEverythingUnlocked function will remain hidden however.

@ASpoonPlaysGames
Copy link
Contributor

ASpoonPlaysGames commented Sep 29, 2023

These changes should probably be split into three different PRs.

Also, I'm not sure about unlocking the paid items for free with progression enabled tbh

@H0L0theBard
Copy link
Contributor

if we're trying to imitate vanilla, probably shouldn't unlock paid items by default tbh

@uniboi
Copy link
Contributor

uniboi commented Sep 29, 2023

Why not? They are vanilla

@ASpoonPlaysGames
Copy link
Contributor

Why not? They are vanilla

Yeah but they are locked (paid) in vanilla, so if we are imitating vanilla they should also be paid. (yes, entitlements carry over between vanilla and northstar, and buying things works in northstar)

@uniboi
Copy link
Contributor

uniboi commented Sep 29, 2023

You can already equip 'premium' content in Northstar. What is thebpoint to only limit those that choose to play with progression. And if you limit what to equip you can just change it since servers do not check what is equipped

@Zanieon
Copy link
Contributor Author

Zanieon commented Sep 29, 2023

I agree with Uniboi on this, i got a plenty of players saying that they simply don't wanna enable progression because they don't wanna lose access to those paid stuff.

Having them to pay for that stuff is the ideal option? Yes, but they also might just go and click in "Toggle progression" again and actually never buy them, if they were the minority I wouldn't bother, but most people are willing to sacrifice the whole progression system in exchange of accessing the Prime Titans and the most worthy camos/skin the Titans have, please don't let the progression system become another case like Frontier War.

@ASpoonPlaysGames
Copy link
Contributor

Aight, sure. But either way, this still applies:

These changes should probably be split into three different PRs.

to be more specific:

  • unlocking paid content as one
  • concommand for resetting aegis ranks as one
  • that change i see in the diffs for the loadout validation should be one

@Zanieon
Copy link
Contributor Author

Zanieon commented Sep 29, 2023

Splits done.

Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks and a question

@ASpoonPlaysGames ASpoonPlaysGames added the needs testing Changes from the PR still need to be tested label Sep 29, 2023
Co-authored-by: Jack <[email protected]>
@ASpoonPlaysGames ASpoonPlaysGames changed the title Improvements to Progression system Unlock paid items with progression enabled Oct 1, 2023
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, PR has been split up

@ASpoonPlaysGames
Copy link
Contributor

Github actions having problems, can't even force a re-run since it thinks there are no jobs.

A commit should give it a kick though

ASpoonPlaysGames and others added 2 commits October 1, 2023 20:22
Github actions having a moment, so I'm making a random whitespace change to trigger it again
Copy link
Contributor

@uniboi uniboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing. Both prime Titans and paid Titan camos stay available when enabling progression.

Same with paid gun skins like for the R-201.

@GeckoEidechse GeckoEidechse removed the needs testing Changes from the PR still need to be tested label Oct 11, 2023
@GeckoEidechse GeckoEidechse added the READY TO MERGE This mergeable right now label Oct 11, 2023
@GeckoEidechse GeckoEidechse merged commit bdb2fa3 into R2Northstar:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants