-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unlock paid items with progression enabled #726
Unlock paid items with progression enabled #726
Conversation
These changes should probably be split into three different PRs. Also, I'm not sure about unlocking the paid items for free with progression enabled tbh |
if we're trying to imitate vanilla, probably shouldn't unlock paid items by default tbh |
Why not? They are vanilla |
Yeah but they are locked (paid) in vanilla, so if we are imitating vanilla they should also be paid. (yes, entitlements carry over between vanilla and northstar, and buying things works in northstar) |
You can already equip 'premium' content in Northstar. What is thebpoint to only limit those that choose to play with progression. And if you limit what to equip you can just change it since servers do not check what is equipped |
I agree with Uniboi on this, i got a plenty of players saying that they simply don't wanna enable progression because they don't wanna lose access to those paid stuff. Having them to pay for that stuff is the ideal option? Yes, but they also might just go and click in "Toggle progression" again and actually never buy them, if they were the minority I wouldn't bother, but most people are willing to sacrifice the whole progression system in exchange of accessing the Prime Titans and the most worthy camos/skin the Titans have, please don't let the progression system become another case like Frontier War. |
Aight, sure. But either way, this still applies:
to be more specific:
|
This reverts commit a1ea16b.
Splits done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicks and a question
Co-authored-by: Jack <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, PR has been split up
Github actions having problems, can't even force a re-run since it thinks there are no jobs. A commit should give it a kick though |
Github actions having a moment, so I'm making a random whitespace change to trigger it again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working in testing. Both prime Titans and paid Titan camos stay available when enabling progression.
Same with paid gun skins like for the R-201.
When turning on progression now, items that should be purchased from the store will remain unlocked, the reason is that i noticed the majority of players don't want to enable progression solely because the store camos in their Titans/Weapons, or using Prime Titans entirely, the developer profile banners and icon patches exposed from the DevEverythingUnlocked function will remain hidden however.