-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement _grunt_chatter_mp.gnut
#687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks pretty good, some examples of testing would be nice if possible
(oh also accidental whitespace change in another file)
Northstar.CustomServers/mod/scripts/vscripts/ai/_ai_soldiers.gnut
Outdated
Show resolved
Hide resolved
For testing with this file is super easy, just go into random Attrition and kill an enemy Grunt, some other grunt nearby will probably speak about the one you just killed, leave only one of their squad alive, and he will probably yell that he's alone and need backup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small improvements, looks good otherwise
PlayGruntChatterMPLine( lastSquadMember, "bc_squaddeplete" ) | ||
} | ||
|
||
void function GruntChatter_TryEnemyDown( entity deadGuy ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
void function GruntChatter_TryEnemyDown( entity deadGuy ) | |
void function GruntChatter_TryEnemyTitanDown( entity deadGuy ) |
Just to make the naming a bit clearer
Northstar.CustomServers/mod/scripts/vscripts/conversation/_grunt_chatter_mp.gnut
Outdated
Show resolved
Hide resolved
Northstar.CustomServers/mod/scripts/vscripts/conversation/_grunt_chatter_mp.gnut
Outdated
Show resolved
Hide resolved
Co-authored-by: uniboi <[email protected]>
Co-authored-by: uniboi <[email protected]>
_grunt_chatter_mp.gnut
Code is adapted from
_grunt_chatter.gnut
which is used in the campaign.File implementation is a vanilla behavior restoration of Grunts being able to chatter about when other grunts nearby are killed, or when an enemy Titan is killed.