Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement _grunt_chatter_mp.gnut #687

Merged
merged 14 commits into from
Oct 10, 2023
Merged

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Aug 21, 2023

Code is adapted from _grunt_chatter.gnut which is used in the campaign.

File implementation is a vanilla behavior restoration of Grunts being able to chatter about when other grunts nearby are killed, or when an enemy Titan is killed.

Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks pretty good, some examples of testing would be nice if possible

(oh also accidental whitespace change in another file)

@ASpoonPlaysGames ASpoonPlaysGames added the needs testing Changes from the PR still need to be tested label Aug 25, 2023
@Zanieon
Copy link
Contributor Author

Zanieon commented Sep 3, 2023

For testing with this file is super easy, just go into random Attrition and kill an enemy Grunt, some other grunt nearby will probably speak about the one you just killed, leave only one of their squad alive, and he will probably yell that he's alone and need backup.

@Zanieon Zanieon requested a review from uniboi October 9, 2023 14:58
Copy link
Contributor

@uniboi uniboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small improvements, looks good otherwise

PlayGruntChatterMPLine( lastSquadMember, "bc_squaddeplete" )
}

void function GruntChatter_TryEnemyDown( entity deadGuy )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
void function GruntChatter_TryEnemyDown( entity deadGuy )
void function GruntChatter_TryEnemyTitanDown( entity deadGuy )

Just to make the naming a bit clearer

@Zanieon Zanieon added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested labels Oct 9, 2023
@GeckoEidechse GeckoEidechse changed the title Implement _grunt_chatter_mp.gnut Implement _grunt_chatter_mp.gnut Oct 10, 2023
@GeckoEidechse GeckoEidechse merged commit 9eede60 into R2Northstar:main Oct 10, 2023
3 checks passed
@Zanieon Zanieon deleted the gruntspeech branch October 10, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now vanilla parity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants