-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display origin auth failure in a dialog #648
Display origin auth failure in a dialog #648
Conversation
Do you plan on adding other languages? |
I would like to tbh, but I'm not rly fussed at this point |
There's no need to add other languages in original PR. We got a weblate setup via translate.harmony.tf where it will show any untranslated strings and translators can add them via weblate once the PR has been merged. |
We gotta be careful about merging in all translations before releasing, then. |
Eh, like we don't even have everything translated yet, so if we do that we would just wait forever |
French is now 100% 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Colour and layout looks good, the help will now take the common errors to the right wiki section. Code is kept to a minimum ( thats good ).
I've also tested this pretty thoroughly when making the colours and designing the UI. But if someone else can test this that would be great. Best way I found is to change your origin token with a debugger to get a bad response back from stryder when you try and auth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Information exposed in R2Northstar/NorthstarLauncher#468 is correctly displayed in a dialog.
(test done by manually corrupting the uidStr
variable through the debugger)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, the link opened automatically jumps to the correct position in the troubleshooting section ( I made a PR for that )
Otherwise this will help with tickets and finding the issue, and hopefully prevent some
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signing off based on reviewer feedback. Did not really properly look at this myself.
Currently, we don't do anything with origin auth failure, meaning the next request just fails, and we get not particularly relevant error messages (player not found, invalid masterserver token)
Depends on
Still todo: