Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of Autohook from buildainfile.cpp #824

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ASpoonPlaysGames
Copy link
Contributor

Code review:

  • The original function is prefixed with o_p so any times where the old AUTOHOOK was calling the original function it should now be calling that instead.
  • The hook function is prefixed with h_ so any times where we would be wanting to call the hooked function from other functions should now be calling that instead

Testing:

  • Check logs to make sure that all of the changed hooks are being created properly
  • Make sure that ns_ai_dumpAINfileFromLoad still works as expected (dumps AIN files on load)

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant