Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler Warnings #645

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

ASpoonPlaysGames
Copy link
Contributor

this build will absolutely fail all the time because warnings are fatal :)

but yeah

@GeckoEidechse GeckoEidechse changed the title Warnings Compiler Warnings Jan 21, 2024
@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Jan 21, 2024
@github-actions github-actions bot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Jan 21, 2024
@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Feb 4, 2024
@github-actions github-actions bot added merge conflicts Blocked by merge conflicts, waiting on the author to resolve and removed merge conflicts Blocked by merge conflicts, waiting on the author to resolve labels Feb 14, 2024
PRIVATE -Wall
-Wextra
-Wpedantic
-Werror
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not make warnings fatal by default.
what is and isn't a warning can change a lot between compiler versions causing phantom errors that only appear in the CI but not locally or the other way around.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly i dont think this PR is ever gonna get merged, since it should really get split up into a bunch more PRs, so I think that it's ok to have fatal warnings on this branch specifically, so that it sort of "proves" that i didnt miss any.

@ASpoonPlaysGames ASpoonPlaysGames marked this pull request as draft March 13, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflicts Blocked by merge conflicts, waiting on the author to resolve
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants