Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enforce Thunderstore format for remote mods #535

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

Alystrasz
Copy link
Contributor

Implements #503 for remote mods (i.e. mods located in the %profile%/runtime/remote/mods directory), expecting them to be named after the AUTHOR-MOD-VERSION pattern.

Testing this

Put mods respecting the Thunderstore format in the remote mods directory, and they should be loaded and usable just like mods located in the packages directory.

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 2, 2023
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing.
I took GeckoEidechse-Titanfall_Slander-0.0.1 and put it under R2Northstar\runtime\remote\mods and it loaded fine.
Renaming to GeckoEidechse-Titanfall_Slander-lol-0.0.1 cause the mod loading to fail as expected due to not matching the required format.
I also verified that normal package and mod loading still works by sticking the same mod inpackages/ and mods/ while formatting it accordingly.

As for code review, all this PR does is basically move the mod loading for remote mods from the logic that deals with "classic" mods to the one that deals with Thunderstore mods. So it looks like a lot of changed lines while the logical change is actually rather small.

@GeckoEidechse GeckoEidechse removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 14, 2023
@GeckoEidechse GeckoEidechse merged commit e51d345 into R2Northstar:main Sep 14, 2023
@GeckoEidechse
Copy link
Member

ugh, just as I merged I forgot to remove myself as co-author for updating branch, whoops x_x

@Alystrasz Alystrasz deleted the feat/remote-mods-formatting branch September 14, 2023 22:41
@Alystrasz Alystrasz mentioned this pull request May 16, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants